[rush-daemon][WS2.8][7/9] Wire request admission - #7
Open
mojaza wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved review findings remain in admission handling and command classification.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds WS2.8 workspace-scoped request admission for opt-in phased and global Rush daemon routing.
Changes:
- Adds scheduling, cancellation, timeouts, queue positions, and lease lifecycle handling.
- Classifies Rush commands and shares admission across routes.
- Extends protocol contracts, documentation, API reports, changesets, and tests.
File summaries
| File | Summary |
|---|---|
libraries/rush-daemon/src/WorkspaceRequestAdmission.ts |
Bridges requests to workspace scheduling. |
libraries/rush-daemon/src/test/RushCommandRequestPolicy.test.ts |
Tests command classification. |
libraries/rush-daemon/src/test/RequestAdmissionIntegration.test.ts |
Tests admission integration and cleanup. |
libraries/rush-daemon/src/test/PhasedRequestRouterTestUtilities.ts |
Supports phased-router admission tests. |
libraries/rush-daemon/src/test/GlobalCommandRequestRouter.test.ts |
Tests global-router admission behavior. |
libraries/rush-daemon/src/RushCommandRequestPolicy.ts |
Defines Rush command classifications. |
libraries/rush-daemon/src/PhasedRequestRouter.ts |
Integrates admission with phased routing. |
libraries/rush-daemon/src/PhasedRequestClient.ts |
Adds phased client admission capabilities. |
libraries/rush-daemon/src/GlobalCommandRequestRouter.ts |
Integrates admission with global routing. |
libraries/rush-daemon/src/GlobalCommandRequestClient.ts |
Adds global client admission capabilities. |
libraries/rush-daemon/src/GlobalCommandRequest.ts |
Carries global admission options. |
libraries/rush-daemon/README.md |
Documents daemon admission behavior. |
libraries/rush-daemon-protocol/src/test/RequestAdmission.test.ts |
Tests admission validation. |
libraries/rush-daemon-protocol/src/test/ControlFrame.test.ts |
Tests control protocol behavior. |
libraries/rush-daemon-protocol/src/RequestAdmissionControlValidation.ts |
Validates admission controls. |
libraries/rush-daemon-protocol/src/index.ts |
Exports admission contracts. |
libraries/rush-daemon-protocol/src/DaemonRequestAdmission.ts |
Defines admission options and results. |
libraries/rush-daemon-protocol/src/DaemonProtocolVersion.ts |
Advances the protocol version. |
libraries/rush-daemon-protocol/src/DaemonPhasedRequest.ts |
Carries phased admission options. |
libraries/rush-daemon-protocol/src/DaemonControlMessage.ts |
Adds queue-position messages. |
libraries/rush-daemon-protocol/src/DaemonControlKinds.ts |
Defines the queue-position control kind. |
libraries/rush-daemon-protocol/src/DaemonCommandResult.ts |
Adds typed admission failures. |
libraries/rush-daemon-protocol/src/DaemonClientCaps.ts |
Adds admission capability negotiation. |
libraries/rush-daemon-protocol/src/ControlMessageValidation.ts |
Wires control-message validation. |
libraries/rush-daemon-protocol/README.md |
Documents protocol admission additions. |
common/reviews/api/rush-daemon.api.md |
Updates the daemon API report. |
common/reviews/api/rush-daemon-protocol.api.md |
Updates the protocol API report. |
common/changes/@rushstack/rush-daemon/mojazayeri-request-admission_2026-08-21-22-37.json |
Records daemon changes. |
common/changes/@rushstack/rush-daemon-protocol/mojazayeri-request-admission_2026-08-21-22-37.json |
Records protocol changes. |
Review details
- Files reviewed: 29/29 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+120
to
+123
| graphLease = await routingState.graphExecutionScheduler.acquireAsync({ | ||
| abortSignal: client.abortSignal, | ||
| exclusivityClass: RequestExclusivityClass.Exclusive | ||
| }); |
| export const BUILT_IN_RUSH_COMMAND_CLASSIFICATION: Readonly<Record<string, RequestExclusivityClass>> = | ||
| Object.freeze({ | ||
| add: RequestExclusivityClass.Exclusive, | ||
| alert: RequestExclusivityClass.SharedRead, |
Comment on lines
+51
to
+54
| export function classifyRushCommand(commandName: string): RequestExclusivityClass { | ||
| return Object.hasOwn(BUILT_IN_RUSH_COMMAND_CLASSIFICATION, commandName) | ||
| ? BUILT_IN_RUSH_COMMAND_CLASSIFICATION[commandName] | ||
| : RequestExclusivityClass.Exclusive; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WS2.8 scheduler classification and request admission for the opt-in rushd phased/global routing stack.
Depends on #6. This stack follows merged microsoft#5949 and advances microsoft#5897. Azure PBI: https://onedrive.visualstudio.com/EFun/_workitems/edit/3216024
Details
SHARED-BUILD,SHARED-READ, orEXCLUSIVE, with unknown/custom commands failing closed toEXCLUSIVE.RequestSchedulerper warm workspace across phased and global routes.noWait/boundedwaitTimeoutMsadmission options, cancellation while queued, capability-gated one-based queue-position controls, and deterministic typed admission results.Limitations
--no-waitand--wait-timeoutremains deferred to WS4; this layer accepts resolved typed values only.SHARED-BUILDrequests may hold admission concurrently, but the phased router intentionally retains its existing graph-execution lock. WS2.9 will add coordinated selection merging.@rushstack/rush-daemon.How it was tested
rush build --only @rushstack/rush-daemon-protocol --only @rushstack/rush-daemonrush change --verify