Skip to content

Fix close button - #7057

Closed
creeperkatze wants to merge 4 commits into
modrinth:mainfrom
creeperkatze:fix/7055-close-button-hover-icon-color
Closed

Fix close button#7057
creeperkatze wants to merge 4 commits into
modrinth:mainfrom
creeperkatze:fix/7055-close-button-hover-icon-color

Conversation

@creeperkatze

Copy link
Copy Markdown
Contributor

Fixes #7055

@modrinth-bot

Copy link
Copy Markdown
Member

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@creeperkatze

Copy link
Copy Markdown
Contributor Author

Before:

20260808-1036-34 5030709

After:

20260808-1036-00 2209370

@Prospector

Copy link
Copy Markdown
Member

the button's only meant to be red background on hover, not sure why the icon was made to be red

@creeperkatze

Copy link
Copy Markdown
Contributor Author

the button's only meant to be red background on hover, not sure why the icon was made to be red

Fixed this cleanly by adding a new hover only interaction type.

20260808-2050-54 0785053

@IMB11

IMB11 commented Aug 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Waiting for
  • -closed [📌 queue requirement]
All conditions
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [📌 queue requirement]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • github-review-approved [🛡 GitHub branch protection]
      • any of [🛡 GitHub branch protection]:
        • check-success = Lint and Test
        • check-neutral = Lint and Test
        • check-skipped = Lint and Test

@IMB11

IMB11 commented Aug 10, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Aug 10, 2026

Copy link
Copy Markdown

queue

☑️ Command queue ignored because it is already running from a previous command.

@IMB11

IMB11 commented Aug 10, 2026

Copy link
Copy Markdown
Member

CI is dying so will just fix this in #7067

@IMB11 IMB11 closed this Aug 10, 2026
@IMB11

IMB11 commented Aug 10, 2026

Copy link
Copy Markdown
Member

4d4fa86 - was originally just gonna drop this commit in favour of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[UI] New red X icon is invisible when hovering

4 participants