Skip to content

Switch pnpm-config.json from globalNeverBuiltDependencies to globalOnlyBuiltDependencies allowlist #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −19
Draft

Switch pnpm-config.json from globalNeverBuiltDependencies to globalOnlyBuiltDependencies allowlist #5955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions common/config/rush/pnpm-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,22 +535,6 @@
}
},

/**
* The `globalNeverBuiltDependencies` setting suppresses the `preinstall`, `install`, and `postinstall`
* lifecycle events for the specified NPM dependencies. This is useful for scripts with poor practices
* such as downloading large binaries without retries or attempting to invoke OS tools such as
* a C++ compiler. (PNPM's terminology refers to these lifecycle events as "building" a package;
* it has nothing to do with build system operations such as `rush build` or `rushx build`.)
* The settings are copied into the `pnpm.neverBuiltDependencies` field of the `common/temp/package.json`
* file that is generated by Rush during installation.
*
* PNPM documentation: https://pnpm.io/package_json#pnpmneverbuiltdependencies
*/
"globalNeverBuiltDependencies": [
// The postinstall script redundantly downloads the platform binding, which PNPM installs as an optional dependency.
"unrs-resolver"
],

/**
* The `globalOnlyBuiltDependencies` setting specifies which dependencies are permitted to run
* build scripts (`preinstall`, `install`, and `postinstall` lifecycle events). This is the inverse
Expand All @@ -570,9 +554,7 @@
* "@swc/core"
* ]
*/
// "globalOnlyBuiltDependencies": [
// "esbuild"
// ],
"globalOnlyBuiltDependencies": ["esbuild", "@swc/core", "@vscode/vsce-sign", "keytar"],

/**
* The `globalIgnoredOptionalDependencies` setting suppresses the installation of optional NPM
Expand Down