[rush-daemon] Add concurrency regression test for serialized invalidation reconciliation - #5951
Draft
Mo Jazayeri (mojaza) with Copilot wants to merge 1 commit into
Draft
[rush-daemon] Add concurrency regression test for serialized invalidation reconciliation#5951Mo Jazayeri (mojaza) with Copilot wants to merge 1 commit into
Mo Jazayeri (mojaza) with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment from PR #5949
[rush-daemon] Add concurrency regression test for serialized invalidation reconciliation
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review feedback to verify
WorkspaceEngineComponentFactoryreconciliation behavior under concurrent calls. The test suite previously validated reconciliation outcomes but did not assert queue/serialization guarantees that protect snapshot handoff and ordering.What changed
WorkspaceEngineComponentFactory.test.tsthat:getInputsSnapshotAsync()call,reconcileInvalidationsAsync()before the first completes,currentInputsSnapshot,Why this matters