Repository navigation
fix(server): preserve zero-valued terminal dataset IDs - #660
Open
Quanxin Liu (notoufa) wants to merge 1 commit into
Open
Quanxin Liu (notoufa) wants to merge 1 commit into
Quanxin Liu (notoufa) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #659
GET /api/rollouts/terminalturns numeric dataset ID0into an empty string, or incorrectly replaces it withinstance_id. Select the fallback only for a missing, null or empty primary ID, then stringify the selected value. Stored inputs, completion cursors and the trainer's internal UUID grouping are unchanged.Nine public HTTP cases cover zero in both fields, primary precedence and existing string/missing/null/empty behavior. On unchanged main: four fail, five pass. After the fix, the complete server/client/package suites pass: 58 tests on native Windows / Python 3.12.7. Repository-wide Ruff lint/format, copyright headers, configured commit hooks, targeted Pyright and
git diff --checkpass. The gateway guide documents ID projection semantics.Dependencies were installed from declared ranges, not the frozen lockfile. The optional VERL/CPU training and real Kubernetes/GPU paths were not run. No model requests or external services were used.
AI assistance: Codex investigated, reproduced, implemented, tested and checked this change. No separate human review is claimed.