Repository navigation
Use typing_extensions Sentinel for NOT_PASSED in parameter tests - #8706
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit intoNov 2, 2026
Conversation
Replace the Literal["NOT_PASSED"] string marker with a typing_extensions Sentinel, compare by identity, and require typing_extensions>=4.16.0 for the test extra.
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
November 2, 2026 06:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8706 +/- ##
=======================================
Coverage 75.05% 75.05%
=======================================
Files 307 307
Lines 32545 32545
=======================================
Hits 24426 24426
Misses 8119 8119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jens Hedegaard Nielsen (jenshnielsen)
requested a balanced review from Copilot
November 2, 2026 06:43
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR is missing the required newsfragment describing the sentinel migration and updated test dependency.
1 open issue
What changed in this PR
This PR replaces the string-based NOT_PASSED marker with a typing_extensions.Sentinel in QCoDeS parameter tests, preserving the distinction between omitted arguments and explicit values.
Changes:
- Define a shared sentinel and update fixture and test annotations.
- Use identity comparisons when checking for omitted arguments.
- Require
typing_extensions>=4.16.0in the test extra.
| File | Description |
|---|---|
tests/parameter/test_snapshot.py |
Update snapshot test annotations and sentinel comparisons. |
tests/parameter/test_parameter_cache.py |
Update cache test annotations and sentinel comparisons. |
tests/parameter/conftest.py |
Define the sentinel and update fixture return types. |
pyproject.toml |
Add the minimum test dependency for sentinel support. |
Review effort: Balanced
Jens Hedegaard Nielsen (jenshnielsen)
enabled auto-merge
November 2, 2026 13:30
esben (esbenh4)
approved these changes
Nov 2, 2026
Jens Hedegaard Nielsen (jenshnielsen)
deleted the
tests-not-passed-sentinel
branch
November 2, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace the Literal["NOT_PASSED"] string marker with a typing_extensions Sentinel, compare by identity, and require typing_extensions>=4.16.0 for the test extra.