Repository navigation
mcdisplay: filled surfaces at --trace=2 for Monochromator components - #2958
Merged
Merged
Conversation
Replace closed multiline/rectangle outlines with polygon() facets, so --trace=2 shows surfaces; --trace=1 keeps outlines. Monochromator_flat, Monochromator_curved, Monochromator_2foc, Monochromator_pol (slab quads), Monochromator_bent and Monochromator_bent_complex (inner/outer/top/bottom faces per arc segment plus end caps; draw_as_rectangles keeps box()). Display only, no change to simulation results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace closed
multiline/rectangleoutlines withpolygon()facets, so--trace=2shows surfaces;--trace=1keeps outlines (the polygon multiline fallback).Monochromator_flat,Monochromator_curved,Monochromator_2foc,Monochromator_pol: slab quadsMonochromator_bent,Monochromator_bent_complex: inner/outer/top/bottom faces per arc segment plus end caps;draw_as_rectangleskeepsbox()McXtrace has no Monochromator components. Display only, no change to simulation results.
Tested (macOS arm64, clang, CPU):
Test_Monochromators(Mono=1..6),Test_Monochromator_bent,Test_Monochromator_bent_complexwith--trace=2; all run and emitpolyhedronoutput. Not tested: Linux, Windows, GPU, visual check in mcdisplay.🤖 Generated with Claude Code