Repository navigation
mcviewtest: show test runtime in the column headers - #2957
Merged
Merged
Conversation
Reports without walltime show 'Runtime: n/a'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mcviewtest column headers now get one more line,
Runtime: h:mm:ss, taken from_meta.walltimein eachtestresults_<label>.json.Why
mctest already stores the time each label's test run took in
_meta.walltime(ea156ff, from #2950, now onmain), but mcviewtest never displayed it.Notes for review
walltimeand showRuntime: n/a, so they still load.walltimeis the time for that one label's run, not the time since the tool started (theTotal runtime:line mctest prints). In--configmode each column shows its own label's time.get_col_header()on sample metas, with and withoutwalltime. Not run on a real test directory.🤖 Generated with Claude Code