Repository navigation
Spread object copies across available failure domains - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root placement planner could select its first two candidates from the same failure domain even when another eligible domain was available. Select one candidate per domain before filling any remaining copies using the existing candidate order. Deployments with fewer domains than copies retain their fallback behavior.
A regression failed on the old planner with two copies selecting a and b from the same rack instead of a and c from distinct racks. It covers one through five copies across three domains, a single-domain deployment, insufficient nodes, and snapshot restoration with exact committed-byte accounting. CI now runs this guard by exact name and the contributor guide updates its guard counts.
Validation: the regression fails on the old planner and passes with the fix. Complete library suites pass: default features 497 passed and 27 ignored; all features 534 passed and 28 ignored. Ten metadata consensus process tests and one coupled metadata/chunk recovery test pass. The locked all-feature/all-target build check passes. Ignored tests and multi-host validation are outside this change.