Repository navigation
Count all extents in bounded object repair reports - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An object with three mapped pages across two extents reported only two repair candidates when the first extent exhausted the repair budget. The loop now continues counting later extents without repairing them. Candidate bytes include the entire requested range, including pages before a continuation cursor; selected and skipped work remain separate and the repair limit still bounds writes.
The existing cursor regression now checks exact totals and skipped bytes on every pass, one restored replica per call, and remaining damage before any read can heal it. Additional checks cover an offset subrange, an exhausted cursor, and rejection of an invalid cursor without repairs. This test now runs explicitly in CI and the contributor guide records 135 named library guards.
The original failure was reproduced before the fix. All 28 repair tests pass with default features and all features; workflow and contributor guards and all-feature/all-target checks pass. The full all-feature library suite reports 531 passing, 2 failing and 28 ignored tests. The remaining failures are batched metadata-head accounting expectations and the distributed-readiness format assertion. Full distributed production readiness remains unfinished.