Repository navigation
fix(opencode): scope libvirt SSH restriction to IaC ownership - #134
Merged
Merged
Conversation
Chart CI passedRepository hygiene and Helm validation passed. View the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the packaged libvirt recovery skill’s blanket SSH/host-operation prohibition. The owner clarified that this boundary prevents manual changes owned by
tfroot-libvirtfrom bypassing OpenTofu; it does not prohibit authorized Hero SSH diagnostics or separately scoped, explicitly approved host work such as live migration. Establish actual ownership first; a later repository follow-up does not make an operation forbidden.Retain exact-operation/target confirmation for every live mutation, SSH tool and privilege gates, the local OpenTofu prohibition, sensitive-data restrictions, and authoritative firewall/network evidence. No host operation is performed by this change.
Fixes: N/A — owner-requested instruction correction.
Type of change
Validation
test,detect, andpackage opencode-serversucceeded atb9b147040bc8af015792454a4bd1f26e967a18bb; post-publish GitOps update correctly skipped on the PR. CI is the validation environment. No local validation run.Expected checks:
test,detect,package opencode-server. Existing hygiene, strict Helm lint/render, source/render parity and packaging checks remain. Add a unique exact old-paragraph-to-new-boundary historical transform, missing/changed/duplicate-match rejection, prefix/suffix and unrelated-file preservation, source/render policy assertions, and packaged skill byte comparison. Both historical baselines and full parity comparisons remain unchanged. Static tests do not prove agent behavioral compliance.Independent supplied-diff pre-PR reviews at
b9b147040bc8af015792454a4bd1f26e967a18bb: adversarial ADVANCE, infrastructure-security ADVANCE, DevOps ADVANCE; QA COVERED; release-readiness READY. No Critical/High findings. These are independent agent assessments, not GitHub approvals. DevOps flags the consumer coordination below.Impact and rollout
Producer:
makeitworkcloud/charts, targetmain. Five paths: packaged recovery skill, Chart.yaml, chart README, Makefile, and existing memory-pilot/render test file. Chart0.5.8→0.5.9; appVersion/image2.0.22, API selector2, workflows, templates, permissions, MCP integration and consumer source are unchanged. No new dependency or operational artifact.40622645966.kustomize-clusterpin PR with auto-merge enabled, gated by destination checks. Verified consumermainat15ddc751beae462600c260094907b49b92fc2a7epins0.5.8;.github/workflows/test.yml::test_chart_pin_and_selector_coupledexpects(0.5.8, 2). The future generated0.5.9pin PR must also update that exact assertion to(0.5.9, 2)in the same PR. Pin-only automation cannot pass it. Do not merge an assertion-only precursor or bypass checks. No consumer edit is included here.0.5.8, with the consumer exact assertion coordinated; not an application-image downgrade.Safety and secrets
AI-assisted implementation and independent review. This PR does not authorize any Hero SSH command or host mutation, merge, publication, or deployment.