Repository navigation
feat: approve company members by exact email domain - #206
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
makeitfutureDev
marked this pull request as ready for review
October 28, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Company members currently require manual operator approval. This adds Admin UI → Users → Auto-approval with an opt-in list of exact email domains. Matching provider identities gain Approved access before engine selection; Admin privileges, channel restrictions and admission limits remain unchanged.
Slack uses a fresh human profile lookup (
users:read.emailrequired). Google Chat/Teams use authenticated provider sender email when present. Manual revocation records an opt-out, and policy removal retains existing approvals. Existing known Slack users can be previewed in bounded batches and explicitly approved; apply re-fetches identities and checks the current policy and opt-outs under the store write lock. Policy changes and automatic approvals are audited.Validation at candidate
78f9b98afe1fff91ab1e3b0a00e185c1ac2a0c76:Release gates still pending:
This draft is not a release-ready candidate. Main and the served checkout have not been modified.
Maintainer decision: explicitly instructed to deploy to main and test later. Live acceptance and private QA recording are deferred, not recorded as passes. Node 22.13 and Node 24 CI test jobs passed. CI hygiene failed on the existing dependency advisories; documentation validation failed on the existing missing
list_email_accountscontrol reference. These outstanding checks remain recorded for follow-up.