Repository navigation
Conversation
Route inherited checkpoint reads, terminal intent and journal reconciliation through the transport's selected runtime, matching its CLI calls. Keep implicit source-registry routing when ordinary MCP has no explicit runtime override. Cover File/SQLite read, resume and replay with an independent Chat root, retaining the original result, journal and single quota debit. Signed-off-by: song <22676124+songoow@users.noreply.github.com>
Build receipt-proof and effect/purpose indexes once per captured history so missing read receipts do not repeatedly scan every historical row. Preserve first-proof ordering, all competing attempts, artifact verification, original identities and read-only observation. Cover bounded traversal, missing work/direction reads and duplicate or malformed competing rows. Signed-off-by: song <22676124+songoow@users.noreply.github.com>
Mark the three functions that directly use the Windows sharing helper, covering ten parameterized cases while retaining twelve portable cases on non-Windows platforms. Signed-off-by: song <22676124+songoow@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复目标
基于 loopx-project/loopx#5677 的当前提交
ebb8375797936aea79a0f3de04fd007aa30d2e26，修复 本轮 review 已复现的三个 P2。此补丁仅包含 3 个 DCO 签署提交、8 个文件，+228/-53。原 PR 的作者 fork 对当前 GitHub integration 的 Git tree 写入和 PR 创建均返回 403。修复提交已发布在
songoow/loopx:codex/pr5677-review-fixes；本 PR 使用主库审阅基线codex/pr5677-fix-base-ebb837579，该分支精确指向原 headebb837579，因此差异仅包含本次补丁。原 PR 分支尚未改变，作者可将下面三个提交整合回原分支；本 PR 合入审阅基线也不会自动更新 #5677 或 main。6bfb611f841f0fa6f5c5315ba41ff001f3de41ae— Chat runtime routingf4b66a193415a24255bb2bd373b40123a1c727ca— checkpoint history indexeseaea1d4ed6ed7efa3d521a059bafb6d4ce0ac084— Windows-only test scope改动与行为
1. Chat checkpoint 始终使用选定的 runtime
在既有 MCP control plane 内复用
effective_runtime_root，使原 Turn、checkpoint policy、terminal intent、cadence、journal reconciliation 和 Chat CLI 选择一致。显式 transport override 与解析后的 runtime 分开：普通 MCP 保留
None，因此仍沿 global registry 的source_registry读取源 provider。Chat 使用已经选定的 root，不再因为缺少common_runtime_root而误读默认 runtime。复用真实 File/SQLite 回归，覆盖注册 root、独立 Chat root、实际 Chat snapshot、read→resume→repeat、原始 identity/结果/journal 保留及一次扣额。额外验证隐式 source 路由不创建第二份 authority。
2. 缺失读取凭据的历史恢复只建立一次索引
在单次捕获的 history 内构造 receipt-name→proof 和 effect/purpose→attempt rows 索引，消除每张待恢复回执重复扫描整段历史的平方增长。
保留 first-proof 顺序、全部竞争记录、完整 identity 与 artifact 核验。合法 proof 与非 null attempt 的判定继续分开，损坏的竞争行不会被过滤或覆盖。没有全局缓存、历史截断、读取时修写或 timeout 调整。
新增回归同时覆盖 work/direction 两类回执删除或损坏、原身份恢复、重复和 malformed 竞争行拒绝、只读观察，以及 1/100/1,000 Turn 下受历史行数常数倍约束的实际属性访问。相同新增增长回归在原 head 两项均失败；修复后通过。
3. Windows sharing 测试精准声明平台
只为直接调用 Windows sharing helper 的三个测试函数添加平台条件，覆盖其展开后的 10 个节点。其余 12 个跨平台用例继续在 Linux 执行。
验证
upstream/main作为 main/base 通过测试范围存在重叠，以上结果不累加成总体通过数。公开边界扫描的 warnings 包括未配置本地 registry 和非字面量 credential 引用；本次新增行未包含凭据、私人状态或本机绝对路径。
原失败 workload 的性能对照
沿用同一份 4,000 个已结算 Turn 的合成持久化历史、artifacts 和 rollout，调用真实生产 observer/RPC：
没有增加默认请求预算。探针结束后两个隔离 daemon 均确认停止。这是 synthetic history 上的真实 source/RPC 对照，不代表 4,000 次实际 provider/CLI 工作或长期生产负载资格。
保留的失败与验证边界
完整 Python 尝试使用
--maxfail=3，在 4,197 passed / 599 skipped / 1,903 subtests passed 后因三项失败停止：test_only_the_owner_module_states_a_whole_value_digest_shape：heartbeat_receipt.py:849的 digest literal 冲突；已在干净原 headebb837579单独复现同一失败，本次未修改该路径。test_native_codex_profile_skill_versions.py安装用例：保存的 npm 日志均显示隔离 HOME 内依赖 tarball 下载连续EAI_AGAIN registry.npmjs.org，最终安装退出 1。相关 installer、profile、测试和 package/lock 相对原 head 均未改动；核心 skill-version/runtime-shutdown 断言尚未执行。因此 不宣称完整 Python suite 全绿。本轮没有执行原生 Windows、完整 real PostgreSQL、真实模型或安装后的 UI 旅程；该补丁不改变页面布局/文案，已验证实际 Chat controller 与原生 checkpoint/CLI backend。原 PR 的平台前置拆分及与 main 的整合仍保持原来的边界。
三个提交分别对应 runtime routing、history recovery 和 Windows test scope；发布内容树
dedddcfec2759dfd6134b8bad68fef027e3d6e23已逐次与本地验证提交的树校验一致。最终补丁 head：eaea1d4ed6ed7efa3d521a059bafb6d4ce0ac084。