chore: introduce DevelopmentTokenSource and deprecate SandboxTokenSource - #230
Merged
Conversation
MaxHeimbrock
force-pushed
the
lukas/dev-token-source
branch
from
August 10, 2026 11:26
4eb6d27 to
4d92031
Compare
Contributor
|
This is where we need to bump the samples as well: https://github.com/livekit-examples/cpp-example-collection/tree/main/token_source |
Contributor
|
Deprecation looks good: |
MaxHeimbrock
marked this pull request as ready for review
August 10, 2026 12:40
MaxHeimbrock
requested review from
alan-george-lk,
stephen-derosa and
xianshijing-lk
as code owners
August 10, 2026 12:40
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Done in this PR as a follow up: livekit-examples/cpp-example-collection#23 |
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
xianshijing-lk
approved these changes
Aug 11, 2026
| }; | ||
|
|
||
| /// @deprecated Use DevelopmentTokenSource instead. | ||
| using SandboxTokenSource [[deprecated("SandboxTokenSource is deprecated; use DevelopmentTokenSource instead")]] = |
Collaborator
There was a problem hiding this comment.
Nice! Thanks for taking care of the compatability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce DevelopmentTokenSource and deprecate SandboxTokenSource