Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writetrainingdatasetssgfGameWinnerto Black for the valid unscored White-win resultRE[W+]. This selects the Black-win branch when constructing forced result targets. Recognize White correctly while preserving the existing incomplete-record flags and target weighting.Factor only the two bare
B+/W+branches into a file-local helper used by the converter and a native regression. The regression reads actual SGFREproperties, checks both colors plus lowercase/whitespace normalization, verifies the forced win/loss/no-result/score targets, and checks that other result forms are left to their existing handlers. It runs inkatago runtests, so the existing upstream CI exercises it without a model or workflow changes.Validation:
W+ -> Blackmapping: the new regression fails atwinner == testCase.winner.katago runtestspasses, including six accepted result variants and six non-bare-result controls.runoutputtestsencountered the existingsnapshot != NULLassertion atcpp/tests/testsearchnonn.cpp:2657. An unmodified export of based91ea855reproduced the same failure (first run passed, second failed). This is the separate terminal-leaf invariant issue covered by Fix visit-cap test invariants for terminal leaves #1258; this PR does not change those tests or claim an overall output-test pass.Based directly on current upstream
master(d91ea855110dae533f0aada947b2b7d78cc8a4e1), with one commit touching onlywritetrainingdata.cpp,runtests.cpp, andtests.h. This native regression checks result parsing and target construction, not a full SGF-to-NPZ conversion. No fork-specific worker settings, Python harnesses, or CI changes are included.