feat: Implement DataFrame.drop - #42
Conversation
This implements the `drop` method for the `DataFrame` class to allow column dropping, completing a task in `tasks/001-dataframe.md`. Dropping rows by index or using `inplace=True` is explicitly unsupported and raises a `NotImplementedError` due to leanframe's architecture avoiding persistent row indices. The changes are accompanied by comprehensive tests checking column drops, error handling with `errors='ignore'`/`errors='raise'`, and unsupported operations. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This implements the `drop` method for the `DataFrame` class to allow column dropping and index row dropping, completing a task in `tasks/001-dataframe.md`. Dropping rows by index works by applying a `~isin()` filter on the index column IF an explicit index has been set using `.set_index()`. Using `inplace=True` or `level` is explicitly unsupported and raises a `NotImplementedError` due to leanframe's architecture avoiding persistent row indices. The changes are accompanied by comprehensive tests checking column drops, row drops, error handling with `errors='ignore'`/`errors='raise'`, and unsupported operations. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
This implements the `drop` method for the `DataFrame` class to allow column dropping and index row dropping, completing a task in `tasks/001-dataframe.md`. Dropping rows by index works by applying a `~isin()` filter on the index column IF an explicit index has been set using `.set_index()`. The `errors` parameter defaults to `"ignore"` (differing from pandas) as checking for missing values in SQL is inefficient, and explicitly raises a `ValueError` if `errors="raise"` is provided. Using `inplace=True` or `level` is explicitly unsupported and raises a `NotImplementedError` due to leanframe's architecture avoiding persistent row indices. The changes are accompanied by comprehensive tests checking column drops, row drops, error handling logic, and unsupported operations. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
1 participant
DataFrame.dropinleanframe/core/frame.py.dropintasks/001-dataframe.md.tests/unit/test_frame.py.pytestlocally.PR created automatically by Jules for task 403722226119443445 started by @tswast