[WIP] Python improvements and output_dir implementation - #336
Open
drobnyjt wants to merge 7 commits into
Open
Conversation
drobnyjt
changed the title
…:Path instead of fragile string concatenation. Fix hardcoded write buffer size (although it should not matter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes #325
Description
This PR adds an
output_diroption to RustBCA input files; it also switches from string concatenation for file handling to std::path::Path, which is what it should have been in the first place.This PR also does some minor code cleanup of the Python functions that shouldn't make a difference to the user but should keep things easier to maintain.
Tests
make_input_file_and_run.pynow includes a test of theoutput_diroption. All other tests pass.