chore: Track the latest v3 contract test release instead of a pinned alpha - #203
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
chore: Track the latest v3 contract test release instead of a pinned alpha#203devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…alpha Co-Authored-By: jbailey@launchdarkly.com <jbailey@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
Co-Authored-By: jbailey@launchdarkly.com <jbailey@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Follows launchdarkly/go-server-sdk#433.
Describe the solution you've provided
The v3 contract tests pinned the harness to
v3.0.0-alpha.6(bothversionandbranchin the CI/nightly workflows, and the download URL plusVERSIONin the server SDK Makefile). They now useversion: 'v3'with nobranchinput, so the harness downloader resolves the newest publishedv3.*release and CI tracks the latest alpha without further pins. The Makefile's v3 target pullsrun.shfrom the harnessv3branch withVERSION=v3.Describe alternatives you've considered
Bumping the pin to the current alpha, which just repeats the same maintenance later.
Additional context
With the latest v3 alpha (
v3.2.0-alpha.7) the v3 suite now fails 14 tests (anonymous-context attribute redaction,allAttributesPrivatewith slash-prefixed attribute names). These are SDK behavior gaps newly covered by the harness, not a regression from this change — launchdarkly/python-server-sdk#492 fails the same tests. They need either SDK fixes or additions totest-suppressions-fdv2.txtbefore this can merge.How to test: the
test-contract-testsjob should download the newestv3.*release rather thanv3.0.0-alpha.6.Link to Devin session: https://app.devin.ai/sessions/6409748db442482fa8ddc43061f0277d
Requested by: @jsonbailey