Skip to content

chore(PLA-4098): merge WebSocket gateway changes into canary - #1092

Merged
mattmikolay merged 45 commits into
canaryfrom
mattmik/canary-websocket-gateway
Oct 23, 2026
Merged

mattmikolay merged 45 commits into
canaryfrom
mattmik/canary-websocket-gateway

Conversation

@mattmikolay

Copy link
Copy Markdown
Contributor

Description

This PR adds the changes in #1087 and #1085 to the canary branch so that I can test them using a canary release. Those two PRs have already been approved.

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
javascript-ms-teams-connect-example Ready Ready Preview Oct 23, 2026 6:43pm UTC
javascript-nextjs-example Ready Ready Preview Oct 23, 2026 6:43pm UTC
javascript-slack-connect-example Ready Ready Preview Oct 23, 2026 6:43pm UTC
javascript-slack-kit-example Ready Ready Preview Oct 23, 2026 6:43pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df64ad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/client Minor
client-example Patch
guide-example Patch
@knocklabs/expo Patch
@knocklabs/react-core Patch
@knocklabs/react-native Patch
@knocklabs/react Patch
@knocklabs/expo-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear-code

linear-code Bot commented Oct 23, 2026

Copy link
Copy Markdown

PLA-4098

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved. This is a client SDK feature change (WebSocket gateway and related client helpers), not an auto-release, dependency update, or documentation-only PR, so product-team review is required. Assigned reviewers: cjbell, kylemcd.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK approver

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.16667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (canary@6ea98a3). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/client/src/gatewayTransport.ts 98.92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             canary    #1092   +/-   ##
=========================================
  Coverage          ?   76.04%           
=========================================
  Files             ?      140           
  Lines             ?     4495           
  Branches          ?     1310           
=========================================
  Hits              ?     3418           
  Misses            ?      977           
  Partials          ?      100           
Files with missing lines Coverage Δ
packages/client/src/api.ts 91.44% <100.00%> (ø)
packages/client/src/helpers.ts 100.00% <100.00%> (ø)
packages/client/src/gatewayTransport.ts 98.92% <98.92%> (ø)

@mattmikolay
mattmikolay merged commit 31dc35e into canary Oct 23, 2026
14 checks passed
@mattmikolay
mattmikolay deleted the mattmik/canary-websocket-gateway branch October 23, 2026 18:53

This branch was successfully deployed

4 active deployments
Preview – javascript-ms-teams-connect-example — df64ad4d Deployed Oct 23, 2026 by vercel[bot]
Preview – javascript-nextjs-example — df64ad4d Deployed Oct 23, 2026 by vercel[bot]
Preview – javascript-slack-kit-example — df64ad4d Deployed Oct 23, 2026 by vercel[bot]
Preview – javascript-slack-connect-example — df64ad4d Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants