You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(PLA-4090): cache socket URLs with null expiration indefinitely - #1089
This PR updates the socket URL caching logic added by #1085 so that when Switchboard's WebSocket gateway API endpoint (POST /v1/sockets/connect) returns a URL that does not expire, the API client caches the URL indefinitely.
When the gateway API endpoint returns the legacy WebSocket connect URL (wss://api.knock.app/ws/v1/websocket), the response includes an expires_at property set to null:
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.09%. Comparing base (def24a4) to head (3b20fb0).
✅ All tests successful. No failed tests found.
The reason will be displayed to describe this comment to others. Learn more.
Not approved — this is a client SDK behavior change (socket URL caching), not an auto-release, dependency, or docs-only PR. Human review from the product team is needed; no reviewers were assigned in this run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the socket URL caching logic added by #1085 so that when Switchboard's WebSocket gateway API endpoint (
POST /v1/sockets/connect) returns a URL that does not expire, the API client caches the URL indefinitely.When the gateway API endpoint returns the legacy WebSocket connect URL (
wss://api.knock.app/ws/v1/websocket), the response includes anexpires_atproperty set tonull:{ "url": "wss://api.knock.app/ws/v1/websocket", "expires_at": null }This
urlis valid indefinitely, provided clients authenticate the request using a valid API key.Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬