Repository navigation
Add a view-only live view member profile - #493
Open
masnwilliams wants to merge 1 commit into
Open
masnwilliams wants to merge 1 commit into
masnwilliams wants to merge 1 commit into
Conversation
masnwilliams
force-pushed
the
hypeship/live-view-viewer-profile
branch
from
October 27, 2026 21:47
26dda8e to
b6cca85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a view-only Neko member profile for read-only live view links.
ghcr.io/kernel/neko/base:3.0.8-v1.6.4-rc.1, which includes Refuse input from sessions without host permission neko#30 (members without host permission don't send input, clipboard or keyboard changes).neko.yaml: the multiuserusermember becomes a view-only profile (can_host,can_share_media,can_access_clipboard,sends_inactive_cursorandis_adminall false) with its own password, used by the live-view proxy for read-only links.window.KERNEL_LIVE_VIEW_READ_ONLY = true, the viewer starts read-only and answersKERNEL_SET_READ_ONLYunlock requests withreadOnly: true, so it doesn't offer controls the member can't use. Without the flag, behavior is unchanged.The admin member and the default live view behavior are unchanged.
Before merging
The base image is a release candidate from kernel/neko#30. Once that PR merges and
v3.0.8-v1.6.4is published, bump theFROMline to it.Testing
bun test testsin the client: 252 pass, including new cases for read-only links.vue-cli-service buildsucceeds; lint has no new warnings.Note
Medium Risk
Tightens live-view session permissions and depends on a Neko RC for server-side input blocking; misconfiguration could affect who can control the browser, but admin/default paths are unchanged.
Overview
Introduces a view-only Neko member for read-only live view links and aligns the viewer UI with server-enforced input limits.
The chromium-headful image bumps the Neko base to
3.0.8-v1.6.4-rc.1(members without host permission do not send input, clipboard, or keyboard changes).neko.yamlrepurposes the multiuseruseraccount: dedicated passwordlive-view-read-only, withcan_host, media, clipboard, and inactive-cursor permissions turned off.The client adds
resolveReadOnly()so when the live-view proxy setswindow.KERNEL_LIVE_VIEW_READ_ONLY = true, initial mode and parentKERNEL_SET_READ_ONLYunlock requests stay read-only (acknowledgements still reportreadOnly: true). Without that flag, behavior is unchanged. README and unit tests cover the new rules.Reviewed by Cursor Bugbot for commit b6cca85. Bugbot is set up for automated code reviews on this repo. Configure here.