Repository navigation
Enable usage in sans-io / non-async projects. - #33
Open
KrausMatthias wants to merge 2 commits into
Open
KrausMatthias wants to merge 2 commits into
KrausMatthias wants to merge 2 commits into
Conversation
added 2 commits
October 27, 2026 21:09
and retaining async compatibility. Drop trait constraints on Body as the traits do not depend on the Request/Response Body type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the sync APIs use block_on and require the futures/executor. This limits the usage in sans-io / non-async projects:
I suggest to swap Sync And Async APIs and avoid the futures/executor dependency. This resolves the panics and simplifies the API by reducing the number of necessary constraints on the traits.
Changes are intentionally kept minimal. The order of the trait implementations was changed so that differences between the original async implementation and the new sync implementation become visible.
Please let me know if you have any concerns or require any changes.