Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SLHDn51P7snTSyxtuDToEb
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed Changes
SpotifyRateLimitErrorandSpotifyAuthenticationFailedErrorare exported but never raised, and therate_limit.jsonfixture isn't used by any test. A 429 or 401 response was returned as if it were data, then failed in the models with a confusingMissingFielderror. This is the behaviour #417 reported; the fix from #425 appears to have been lost._requestnow raises:SpotifyAuthenticationFailedErroron 401SpotifyRateLimitErroron 429SpotifyNotFoundErroron a 404 status code, in addition to the existing check for a 404 error bodyNew tests cover all three; they fail on
mainand pass with this change.Related Issues
Generated by Claude Code