Skip to content

Allow devices without a volume - #867

Open
joostlek wants to merge 1 commit into
mainfrom
ccr-af58c15a-nqvsya-device-volume-nullable
Open

joostlek wants to merge 1 commit into
mainfrom
ccr-af58c15a-nqvsya-device-volume-nullable

Conversation

@joostlek

Copy link
Copy Markdown
Owner

Proposed Changes

The device object's volume_percent is nullable in the Spotify reference. Device.volume_percent was typed int, so a device reporting null made get_devices, get_playback and anything else returning a device raise InvalidFieldValue.

The field is now int | None. The new test fails on main and passes with this change.

Related Issues


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SLHDn51P7snTSyxtuDToEb
@joostlek joostlek added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Oct 30, 2026 — with Claude
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants