Skip to content

fix(cd): publish 13.0.0, and stop reporting success when nothing publishes #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaneK merged 2 commits into from
Aug 19, 2026
Merged

fix(cd): publish 13.0.0, and stop reporting success when nothing publishes #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe5702c
chore(cd): log npm at verbose so OIDC failures explain themselves
ShaneK Aug 19, 2026
ee162eb
fix(cd): fail the publish step when nothing gets published
ShaneK Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ jobs:
shell: bash
env:
NODE_AUTH_TOKEN: ''
# npm logs every OIDC token-exchange failure at verbose, so at the default
# loglevel a missing or mismatched trusted publisher just surfaces as
# ENEEDAUTH with no reason attached.
NPM_CONFIG_LOGLEVEL: verbose

13 changes: 13 additions & 0 deletions scripts/publish-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,16 @@ for manifest in packages/*/package.json; do
done

echo "published $published package(s)"

# A run that publishes nothing is a failure, not a success. `lerna version` exits 0 when
# it declines to version (an EBEHIND warning on a stale checkout, for example), which
# leaves the manifests at their released versions and makes every package look already
# published. Without this the job goes green having shipped nothing.
if [ "$published" -eq 0 ]; then
echo "error: no packages were published." >&2
echo "The manifest versions above are already on the registry, so the Version step" >&2
echo "did not produce a new release. Check the Version step output rather than" >&2
echo "re-running this job: re-running a workflow checks out its original commit," >&2
echo "which still carries the pre-release versions." >&2
exit 1
fi
Loading