Skip to content

fix(proofs): scan for postulate in check-abi; say exactly what the gate enforces - #165

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/bold-dijkstra-jbt52l
Oct 26, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/bold-dijkstra-jbt52l

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

#163 auto-merged before the fixes for CodeRabbit's two review findings were pushed. Both findings were correct:

  1. Major: PROOF-NEEDS.adoc and docs/proof-debt.adoc said check-abi.sh fails CI on postulate and on holes. Its keyword scan covered only believe_me, assert_total, assert_smaller, idris_crash and unsafePerformIO.
  2. Minor: the proof-debt (d) section called every entry an unsafe block. Four of them, in coprocessor/mod.rs, are unsafe extern "C" fn type declarations.

What changes

  • panel-clades/scripts/check-abi.sh: postulate joins the escape-hatch scan. No .idr file uses it, so the gate still passes.
  • Both ledgers: they now say exactly what CI enforces (the six keywords) and that holes are not scanned. "No holes" stays as a measurement dated 2026-10-26.
  • proof-debt (d): the wording now covers both blocks and declarations.

Verification

  • The scan, run locally with the new pattern over panel-clades/src/abi/PanelClades/**/*.idr, finds no hits (exit 1, the passing case).
  • bash -n on the script is clean.
  • standards' check-trusted-base.sh still passes.

Note: Governance, Hypatia, Secret Scanner and Rust CI will fail at startup here, as they do on main. hyperpolymath/standards was transferred to metadatastician/standards, so the pins no longer resolve; see the #163 comment. This PR doesn't cause or fix that.


Generated by Claude Code

…te enforces

Review on #163 found two overstatements in the reconciled ledgers.

- Both docs said check-abi.sh fails CI on `postulate` and on holes. Its
  keyword scan covered only believe_me, assert_total, assert_smaller,
  idris_crash and unsafePerformIO. `postulate` is now in the scan; no
  .idr file uses it, so the gate still passes. Holes are not scanned,
  and the docs now say so, keeping "no holes" as a dated measurement.
- proof-debt (d) called every entry an `unsafe` block; four are
  `unsafe extern "C" fn` type declarations. The wording now covers both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BCQeL169ZnUirUVaDXQLA3
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2b7c29f1-bfb1-4b83-9ffd-d75e7c87f554
Commits

Reviewing files that changed from the base of the PR and between 1b6e767 and cb3211c.

Files selected for processing: 3
  • PROOF-NEEDS.adoc
  • docs/proof-debt.adoc
  • panel-clades/scripts/check-abi.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review October 26, 2026 22:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:39:57.580070Z cb3211c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 26, 2026 22:40
@hyperpolymath
hyperpolymath merged commit bc601df into main Oct 26, 2026
15 checks passed
@hyperpolymath
hyperpolymath deleted the claude/bold-dijkstra-jbt52l branch October 26, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants