Repository navigation
fix(proofs): scan for postulate in check-abi; say exactly what the gate enforces - #165
Conversation
…te enforces Review on #163 found two overstatements in the reconciled ledgers. - Both docs said check-abi.sh fails CI on `postulate` and on holes. Its keyword scan covered only believe_me, assert_total, assert_smaller, idris_crash and unsafePerformIO. `postulate` is now in the scan; no .idr file uses it, so the gate still passes. Holes are not scanned, and the docs now say so, keeping "no holes" as a dated measurement. - proof-debt (d) called every entry an `unsafe` block; four are `unsafe extern "C" fn` type declarations. The wording now covers both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BCQeL169ZnUirUVaDXQLA3
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |



Why
#163 auto-merged before the fixes for CodeRabbit's two review findings were pushed. Both findings were correct:
PROOF-NEEDS.adocanddocs/proof-debt.adocsaidcheck-abi.shfails CI onpostulateand on holes. Its keyword scan covered onlybelieve_me,assert_total,assert_smaller,idris_crashandunsafePerformIO.unsafeblock. Four of them, incoprocessor/mod.rs, areunsafe extern "C" fntype declarations.What changes
panel-clades/scripts/check-abi.sh:postulatejoins the escape-hatch scan. No.idrfile uses it, so the gate still passes.Verification
panel-clades/src/abi/PanelClades/**/*.idr, finds no hits (exit 1, the passing case).bash -non the script is clean.check-trusted-base.shstill passes.Note: Governance, Hypatia, Secret Scanner and Rust CI will fail at startup here, as they do on
main.hyperpolymath/standardswas transferred tometadatastician/standards, so the pins no longer resolve; see the #163 comment. This PR doesn't cause or fix that.Generated by Claude Code