Repository navigation
feat(ipc): register every panel-backend command, add the event pump - #164
Conversation
The IPC table now covers all 233 panel-backend commands in 42 module groups (the coprocessor pilot from #157 had 10). With the 36 that main.rs registers itself, the desktop shell exposes 269 commands. - Entries follow the pilot's rules: async handlers run through `block_on`, sync ones are called directly; `Option` parameters are optional, struct parameters use `struct_arg`, and `AppHandle` is supplied by the backend. Every required argument was checked against the pre-#107 frontend's `invoke()` calls, and the old frontend sent all of them. - main.rs starts an event pump that drains `compat`'s event bus every 50 ms and hands each event to `gossamer_emit`, which is thread-safe. This delivers AI streaming chunks and file-watcher events. - New test `every_backend_command_is_registered` fails when a public handler in a command module is reachable from neither the table nor main.rs. - Docs: Cargo.toml header, EXPLAINME-new, TECHNICAL_DEBT (F1 and F2 resolved), CHANGELOG, and test counts (285 to 294). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Four checks are red on
I don't know of a fix yet, and the API doesn't return the startup error text. The error is shown on the run page: https://github.com/hyperpolymath/panll/actions/runs/40411215783. Re-running won't help, because the failure happens the same way every time, before any job starts. Rust coverage for this PR comes from the checks that did run and passed: E2E "Rust Backend — Build + Check" (the real Zig/GTK build, link and Generated by Claude Code |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 095360a3a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Two findings from Codex review on #164: - The old frontend sent `save_arrangement` and `save_session` their struct as JSON text (`{"arrangement": "<json>"}`), which `struct_arg` rejected as "invalid type: string". A string value is now parsed as JSON before deserialising. - The event pump thread could call `gossamer_emit` with a freed handle: `gossamer_run` frees it when the event loop exits, before `run()` returns and before the stop flag was set. The pump is now a GLib timeout on the GTK main thread, which only fires inside the event loop while the handle is alive. The thread and the stop flag are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b4f1075c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…test-only items Codex review on #164: multiplayer_monitor/commands.rs declares a #[cfg(test)] TEST_LOCK above its six handlers. Both the generator that built the table and every_backend_command_is_registered cut each file at its first #[cfg(test)], so the six commands were never registered and the test could not notice. The test now cuts at the unit-test module (`#[cfg(test)]\nmod tests`), and the six commands are in the table; with them removed the test lists all six. No other command file has a test-only item above a handler. Counts: 239 table commands, 275 in total. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
|
|
Add Carrot credits or activate Agent usage billing to use Autofix |
Why
#157 added the IPC table (
src-gossamer/src/ipc.rs) with only the 10 coprocessor commands as a pilot. The other panel-backend modules compiled and were tested, but none of their handlers could be called from the webview. That isdocs/TECHNICAL_DEBT.adocF1.What
ipc.rs: the table now registers all 239 panel-backend commands, in 43 module groups. With the 36 commandsmain.rsregisters itself, the desktop shell exposes 275. Each entry follows the pilot's rules:async fnhandlers run throughblock_on; sync handlers are called directly. Several sync handlers usereqwest::blocking, which must not run inside a runtime. I checked that noasync fnhandler uses blocking HTTP.Optionparameters are optional.struct_arg. It accepts a nested object, a flattened payload, or the struct sent as JSON text; the old frontend sentsave_arrangementandsave_sessiontheir struct as a string.AppHandleparameter is supplied by the backend.ums_cartridge::validate_level_data, a helper rather than a command.invoke()calls (git show 7a4f2cf^). The old frontend sent every one of them, so no further empty-means-default cases neededOption(the pilot'slib_pathwas the only one).main.rs). Ag_timeout_addcallback on the GTK main thread drainscompat's event bus every 50 ms and hands each event togossamer_emit. The callback only fires inside the event loop, while the window handle is live.gossamer_runfrees the handle after the loop exits, so no tick can run on a freed handle. This is what makesai_send_message_streamingchunks andwatcher_startevents reach the webview.every_backend_command_is_registered. It scans every*/commands.rs,*_live.rsandworkspace/sysinfo.rs, up to the unit-test module, and fails if a public handler is reachable from neither the table normain.rs. This covers the "command dispatch is total" item inPROOF-NEEDS.adoc.Cargo.tomlheader, EXPLAINME-new, TECHNICAL_DEBT (F1 and F2 marked resolved), the CHANGELOG, the PROOF-NEEDS "IPC dispatch is total" row, and the test counts in README, EXPLAINME-new and TEST-NEEDS (285 → 294).Review follow-ups
Codex raised these, and all were real:
6141af7):struct_argnow parses a string value as JSON before deserialising it.6141af7): the original background thread could callgossamer_emiton a freed handle. It is now the GTK-loop timer described above.multiplayer_monitor(c38063e): its six commands were not registered, and the test didn't notice. A test-onlyTEST_LOCKabove the handlers made both the generator and the test stop reading the file there. The test now cuts at#[cfg(test)] mod tests. With the group removed, it fails and lists all six commands.Checks
cargo fmt --all -- --check: clean.cargo clippy --locked --all-targets -- -D warnings: clean.cargo clippy --locked --features gossamer --all-targets -- -D warnings: clean. This was a type-check against a stublibgossamer. E2E's Rust job does the real Zig/GTK build, link and test; it passed on6141af7.cargo test --locked --lib: 294 passed. That includesrequired_arguments_are_enforced, which sends{}to every entry that has required arguments. All of them reject it before the handler runs, so the test has no side effects.CI not caused by this PR
Rust CI, Governance, Hypatia and Secret Scanner fail at startup on this PR, and also on #162 and #163 (#163 has since merged); see the comment below.
Not tested
🤖 Generated with Claude Code
https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G