Skip to content

fix(studio): the desktop card says the download opens hyperframes.studio - #6594

Merged
ukimsanov merged 1 commit into
mainfrom
fix/editor-card-studio-domain
Oct 28, 2026
Merged

ukimsanov merged 1 commit into
mainfrom
fix/editor-card-studio-domain

Conversation

@ukimsanov

@ukimsanov ukimsanov commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

The browser editor's "Install the desktop app" card said its download "Opens hyperframes.dev in a new tab". Since 27 Oct the link goes to hyperframes.studio (#6585), and hyperframes.dev redirects there. One word in DesktopGuideCard.tsx.

Before

editor-card-before

Step 1 of the card: "Free. Opens hyperframes.dev in a new tab."

After

editor-card-after

"Free. Opens hyperframes.studio in a new tab." Captured from hyperframes preview built from this branch, with /api/open-in-desktop answering "not installed" so step 1 shows.

How it was tested

OpenInDesktopButton.dom.test.tsx 21/21. The card's download button already goes to hyperframes.studio/studio/download?src=browser-editor (live /api/open-in-desktop answer).

Copilot AI balanced review requested due to automatic review settings October 27, 2026 21:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 145 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

Unstable (3)

  • seqplainkeys-none-center-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqplainkeys-none-pct-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqplainkeys-none-pct-r0-nested-z100: tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo false, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DesktopGuideCard.tsx:171 now names the same .studio host returned by desktopDownloadUrl and opened by OpenInDesktopButton; the exact diff is one presentation string, with handlers and routing unchanged. Read the full card/caller/server path and existing peer texts (Copilot quota notice only). Local pinned-source comparisons pass; required checks pass/skip. I did not independently rerun the reported DOM suite or inspect live screenshots/browser behavior.

Verdict: APPROVE
Reasoning: The copy matches the existing download destination, with no behavioral change or code blocker found at this exact head.

— desktop-review

@ukimsanov
ukimsanov added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit dd7290a Oct 28, 2026
111 of 112 checks passed
@ukimsanov
ukimsanov deleted the fix/editor-card-studio-domain branch October 28, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants