Skip to content

fix(client): build the User-Agent from the assembly version #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hazeliscoding merged 1 commit into from
Oct 21, 2026
Merged

fix(client): build the User-Agent from the assembly version #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions QuickbaseNet.UnitTests/Tests/QuickbaseClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ public async Task Constructor_ThrowsArgumentNullException_WhenTokenIsNull()
Assert.Equal("userToken", exception.ParamName);
}

[Fact]
public void Constructor_SetsUserAgentFromAssemblyVersion()
{
// Arrange
var version = typeof(QuickbaseClient).Assembly.GetName().Version!.ToString(3);

// Act
var client = new QuickbaseClient(TestRealm, TestToken);

// Assert
Assert.Equal($"QuickbaseNet/{version}", client.Client.DefaultRequestHeaders.UserAgent.ToString());
}

[Fact]
public async Task QueryRecords_ReturnsSuccessResponse_WhenCalled()
{
Expand Down
2 changes: 1 addition & 1 deletion QuickbaseNet/Services/QuickbaseClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace QuickbaseNet.Services
public class QuickbaseClient
{
private const string BaseUrl = "https://api.quickbase.com";
private const string UserAgent = "QuickbaseNet/1.0.1";
private static readonly string UserAgent = "QuickbaseNet/" + typeof(QuickbaseClient).Assembly.GetName().Version.ToString(3);

/// <summary>
/// Gets or sets the HTTP client used to make requests to the QuickBase API.
Expand Down
Loading