Skip to content

fix: uloop no longer advertises verify-project in help, command lists, or installed skills - #3406

Merged
hatayama merged 1 commit into
mainfrom
chore/hide-verify-project
Oct 27, 2026
Merged

hatayama merged 1 commit into
mainfrom
chore/hide-verify-project

Conversation

@hatayama

Copy link
Copy Markdown
Owner

Summary

  • uloop no longer advertises verify-project: it is left out of --help, uloop list --names, shell completion, the README, and uloop skills install.
  • Unity's official CLI already covers these project-file checks, so this project does not need to offer its own.

User Impact

  • Before: verify-project was listed next to the other commands and its skill was installed into agent skill folders.
  • After: nothing user-facing points agents at it. The command still runs when called by name, so existing calls do not break.
  • A uloop-verify-project skill that was installed earlier stays in place until it is removed by hand; uloop skills install does not delete it.

Changes

  • Mark the native command entry hidden and the skill internal: true, following the compile-check precedent.
  • Drop the skill guidance line from verify-project --help, so help never names a skill that is no longer installed.
  • Remove the generated .claude/ and .agents/ skill copies and the README entries (bundled skill count 23 -> 22).
  • Restamp the shared release inputs for the cli/common change.

Verification

  • scripts/check-go-cli.sh
  • scripts/sync-tool-docs.sh --check
  • go run ./cmd/check-skill-size --root "$(git rev-parse --show-toplevel)" (from cli/release-automation)
  • Built dist/darwin-arm64/uloop: --help no longer lists verify-project, and uloop verify-project still runs and prints its report

Unity's official CLI already covers these project-file checks, so this
project does not need to offer its own. It follows the compile-check
precedent: the command stays routable by name, while nothing user-facing
advertises it.

- Mark its native command entry Hidden and its skill internal, so --help,
  `uloop list --names`, completion, and `uloop skills install` leave it out
- Drop its skill guidance line and the generated .claude/.agents copies, so
  --help never points at a skill that is no longer installed
- Remove it from both READMEs and restamp the shared release inputs
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 57108db and 1842375.

Files selected for processing: 15
  • .agents/skills/uloop-verify-project/SKILL.md
  • .claude/skills/uloop-verify-project/SKILL.md
  • Packages/src/Editor/CliOnlyTools~/VerifyProject/Skill/SKILL.md
  • README.md
  • README_ja.md
  • cli/common/clicore/command_errors_test.go
  • cli/common/clicore/command_registry.go
  • cli/common/clicore/command_registry_test.go
  • cli/common/tooldocs/skill_guidance.go
  • cli/common/tooldocs/skill_guidance_test.go
  • cli/dispatcher/internal/dispatcher/help_test.go
  • cli/dispatcher/internal/dispatcher/verify_project_test.go
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/internal/projectrunner/list_names_test.go
  • cli/project-runner/shared-inputs-stamp.json
Files with no reviewable changes: 3
  • cli/common/tooldocs/skill_guidance.go
  • .agents/skills/uloop-verify-project/SKILL.md
  • .claude/skills/uloop-verify-project/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The verify-project command remains routable but is hidden from visible command listings and completions. Its skill guidance and documentation references are removed, and tests now check these changes.

Changes: verify-project visibility

Layer / File(s) Summary
Hide the command and remove skill guidance
cli/common/clicore/command_registry.go, cli/common/clicore/command_registry_test.go, cli/common/tooldocs/skill_guidance.go, cli/common/tooldocs/skill_guidance_test.go, Packages/src/Editor/CliOnlyTools~/VerifyProject/Skill/SKILL.md
The registry marks verify-project hidden while retaining dispatcher ownership. The command no longer maps to skill guidance, and the skill source is marked internal. Tests check that hidden commands remain routable but do not appear in visible listings or completions.
Update help, listings, and documentation
README.md, README_ja.md, .agents/skills/uloop-verify-project/SKILL.md, .claude/skills/uloop-verify-project/SKILL.md, cli/common/clicore/command_errors_test.go, cli/dispatcher/internal/dispatcher/*_test.go, cli/dispatcher/shared-inputs-stamp.json, cli/project-runner/internal/projectrunner/list_names_test.go, cli/project-runner/shared-inputs-stamp.json
The README files remove the skill listing and command example. The skill guides are deleted. Help and command-name test expectations no longer list verify-project, and the shared-input hashes change.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 18423

The PR consistently hides verify-project from advertised surfaces while preserving direct routing, with no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: verify-project remains runnable but is no longer advertised in help, command lists, or installed skills.
Description check Passed The description directly explains the changes, user impact, implementation, and verification for hiding verify-project while preserving direct execution.
Docstring Coverage Passed Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviv…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 9 functions across 7 files. (5 skipped: 5 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 76ce3f2 into main Oct 27, 2026
15 checks passed
@hatayama
hatayama deleted the chore/hide-verify-project branch October 27, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant