Repository navigation
fix: a dispatcher release no longer reports a false failure while the package release waits behind other release checks - #3380
Conversation
Release PR checks run one pull request at a time in the order gh lists them, newest first, so the package release PR waited behind the project runner's checks. dispatcher-publish's post-publish waits 45 minutes for the package PR's checks, timed out, and reported a release failure even though the release-please run merged the PR afterwards. Putting the package PR first keeps that wait to one check run; the other PRs keep their listed order.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Summary
User Impact
post-publishjob waits 45 minutes for the package pull request's checks, timed out, and filed a release-failure comment, even though the release-please run merged the package release a few minutes later.post-publishwaits for one check run and merges it itself.Changes
orderReleasePRsForChecksmoves the unity-package release pull request to the front before the checks loop; every other pull request keeps its listed order.docs/dispatcher-pin-release-order.md: one sentence on why the package pull request goes first.Verification
gofmt -l,go vet ./...,go test ./...,golangci-lint run ./...,golangci-lint fmt --diff ./...incli/release-automation.