Centre the draft landing's mark+composer optically - #250
Conversation
Upstream anchored the group's top at a fixed 25.375% of the panel — tuned for a wide desktop window. In the tall Amicode webview that beached the mark and composer in the upper third with a hold of empty space below. Replace the anchor with the same grammar the start screen already uses (session-new-view): flex centring plus a pb lift, so the group sits at the optical centre at any panel height.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe new-session content group now uses full-panel flex centering with bottom padding instead of a fixed vertical offset. ChangesNew-session layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized layout change centers the landing mark and composer more consistently across panel heights, with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the problem, implementation, rationale, and verification results. It omits required template sections for the issue, change type, screenshots or recordings for this UI change, and checklist confirmations. ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
Consolidated into #249 (one PR for the day's chat polish, Kate's call) — the landing-centering commit is in that branch verbatim. |
1 participant
Upstream anchored the landing group's top at a fixed 25.375% of the panel height — tuned for a wide desktop window. In the tall Amicode webview that beached the mark and composer in the upper third, with a hold of empty space below (Kate flagged it as visually off balance).
The fix replaces the fixed anchor with the grammar the start screen already uses (session-new-view): flex centring plus a pb-24 lift, so the group sits at the optical centre — slightly above geometric centre — at any panel height. At the webview's proportions the above:below ratio goes from ~1:1.8 to ~1:1.2, and unlike the fixed anchor it holds as the panel grows (the old code degrades to ~1:2.2 at taller panels).
Verified live on :3004 at 815×994 (the webview's css proportions), both schemes. oxlint (baseline), tsgo -b clean.
Summary by CodeRabbit