-
Notifications
You must be signed in to change notification settings - Fork 0
Chat polish: bubble seat, landing centre, blocks land whole with a crisp entrance #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kateebonner
wants to merge
7
commits into
local/amicode
Choose a base branch
from
kate/website-chat-style
base: local/amicode
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b1ff4e
fix(chat): seat the dark prompt bubble at ~85% luminance — no more glare
kateebonner 2bfaeee
fix(timeline): drop the UPDATE eyebrow on prose steps — it said nothing
kateebonner befe048
fix(app): centre the draft landing's mark+composer optically
kateebonner 1ef7c41
fix(chat): seat the dark prompt bubble lower still — ~70% luminance
kateebonner 0d4359c
feat(timeline): blocks land whole, with a crisp entrance — no typing …
kateebonner cab3466
Merge branch 'kate/landing-optical-center' into kate/website-chat-style
kateebonner 69b3aad
Merge branch 'kate/timeline-enter-animation' into kate/website-chat-s…
kateebonner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: harmoniqs/opencode
Length of output: 618
🏁 Script executed:
Repository: harmoniqs/opencode
Length of output: 15179
🏁 Script executed:
Repository: harmoniqs/opencode
Length of output: 1875
🏁 Script executed:
Repository: harmoniqs/opencode
Length of output: 6707
🌐 Web query:
MDN CSS word-break break-word deprecated overflow-wrap anywhere equivalent semantics💡 Result:
The CSS value word-break: break-word is officially deprecated [1][2]. It is maintained solely for legacy compatibility, and developers are advised against using it in new stylesheets [3][4]. The functionality previously provided by word-break: break-word is now better handled by the overflow-wrap property [5][6][3]. Specifically, overflow-wrap: anywhere is the modern, standard-compliant equivalent [1][7][3]. Key points regarding the semantics and differences: 1. Deprecation Status: The W3C CSS Working Group has marked word-break: break-word as deprecated [8]. Some discussions have even proposed normative prohibitions against its use in new code to discourage reliance on this non-standard behavior [4]. 2. Semantics and Behavior: - word-break: break-word was originally introduced to provide a way to break long words while still behaving similarly to normal word-break behavior in other contexts [5][6]. - overflow-wrap: anywhere is designed to allow lines to break at any point if necessary to prevent overflow, essentially providing the robust wrapping behavior developers sought from the deprecated keyword [7][5]. 3. Intrinsic Sizing Differences: - A technical distinction exists regarding how these values interact with min-content intrinsic size calculations [5][6]. - overflow-wrap: anywhere allows the browser to break lines at any point, but importantly, it does not consider these potential break points when calculating min-content intrinsic sizes [7][9]. - In contrast, word-break: break-word does consider soft wrap opportunities introduced by the break when calculating min-content [8][5]. Because overflow-wrap: anywhere avoids the intrinsic sizing side effects of the legacy break-word value, it is generally considered the superior and more predictable choice for preventing text overflow in modern CSS layouts [7][5].
Citations:
Replace the deprecated
word-breakvalue.Use
overflow-wrap: anywherefor long URLs and unbroken strings.🧰 Tools
🪛 Stylelint (17.14.0)
[error] 160-160: Deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated)
(declaration-property-value-keyword-no-deprecated)
🤖 Prompt for AI Agents
Source: Linters/SAST tools