test(agents): mode-card skill-reference closure + autoresearch entry-points re-point - #539
Draft
aarontrowbridge wants to merge 1 commit into
Draft
test(agents): mode-card skill-reference closure + autoresearch entry-points re-point#539aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
…points re-point (#537)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/skill_reference_closure.test.ts): every skill-invocation directive in all agent cards must resolve against repo skills plus the committed internal-registry fixture (develop,director-core,implement-issue); registry entries are cross-checked against the armonissima team mount when present (conditional, same pattern as the mode-card parity suite). Non-vacuous guards on both the card side and the registry side.director-core(canonical loop protocol); this skill is the research-mode instantiation carrying what director-core deliberately does not (spec-gate review budget, checkout registry, probe/experiment boundary). Conflict rule: director-core wins; report the conflict, never resolve it by edit.Born from the 2026-08-23 outage: both mode cards invoke
director-corefirst, the server's staging allowlist omitted it, and runtime died withskill director-core unavailable. CI now catches what staging forgets.Closes #537
Verification
npm test— 107 files / 1515 tests, full suite green (run on this branch)npm run typecheck— clean