Skip to content

test(agents): mode-card skill-reference closure + autoresearch entry-points re-point - #539

Draft
aarontrowbridge wants to merge 1 commit into
mainfrom
537-skill-reference-closure
Draft

test(agents): mode-card skill-reference closure + autoresearch entry-points re-point#539
aarontrowbridge wants to merge 1 commit into
mainfrom
537-skill-reference-closure

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

Summary

  • Closure suite (test/skill_reference_closure.test.ts): every skill-invocation directive in all agent cards must resolve against repo skills plus the committed internal-registry fixture (develop, director-core, implement-issue); registry entries are cross-checked against the armonissima team mount when present (conditional, same pattern as the mode-card parity suite). Non-vacuous guards on both the card side and the registry side.
  • autoresearch skill entry-points re-point: the card's first action invokes director-core (canonical loop protocol); this skill is the research-mode instantiation carrying what director-core deliberately does not (spec-gate review budget, checkout registry, probe/experiment boundary). Conflict rule: director-core wins; report the conflict, never resolve it by edit.

Born from the 2026-08-23 outage: both mode cards invoke director-core first, the server's staging allowlist omitted it, and runtime died with skill director-core unavailable. CI now catches what staging forgets.

Closes #537

Verification

  • npm test — 107 files / 1515 tests, full suite green (run on this branch)
  • npm run typecheck — clean
  • Runtime half hardened server-side the same day: staging script now carries a reference audit; negative control (simulated unstaged director-core) fires the WARN

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68835346-8c4c-4687-979b-42a898db565c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mode-card skill directives must close at CI: reference-closure test + autoresearch entry-points re-point

1 participant