Repository navigation
Order versions by push date instead of committer date - #3
Merged
Merged
Conversation
![clank-halter[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
GitHub's GraphQL API no longer populates Commit.pushedDate (deprecated, "Removal on 2023-07-01 UTC"), so Age() has been falling back to the committer date. Concourse only schedules a `version: every` input ranked above the newest version the job has already built, and a rebased commit keeps an old committer date, so pushes of rebased stacks were ranked below the cursor and never built. Take the push time from the repository activity API instead, looking up only pull requests updated since the last version. A push the repository has not recorded yet is left for the next check so a version's date never changes; forks fall back to the committer date. A version that only names a pull request (fly check-resource --from pr:N) now produces just that pull request's tip rather than every open pull request. The README's pre-existing markdownlint violations (heading levels, a pipe inside a table cell, a bare "here" link) are fixed so the edit can pass the lint hook. Co-Authored-By: clank-halter[bot] <2696940+clank-halter[bot]@users.noreply.github.com> Clank-Job-Id: 62103f95-6af0-4f16-9d96-36e5cac5a5c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's GraphQL API no longer populates Commit.pushedDate (deprecated,
"Removal on 2023-07-01 UTC"), so Age() has been falling back to the
committer date. Concourse only schedules a
version: everyinput rankedabove the newest version the job has already built, and a rebased commit
keeps an old committer date, so pushes of rebased stacks were ranked below
the cursor and never built.
Take the push time from the repository activity API instead, looking up
only pull requests updated since the last version. A push the repository
has not recorded yet is left for the next check so a version's date never
changes; forks fall back to the committer date. A version that only names
a pull request (fly check-resource --from pr:N) now produces just that
pull request's tip rather than every open pull request.
The README's pre-existing markdownlint violations (heading levels, a pipe
inside a table cell, a bare "here" link) are fixed so the edit can pass
the lint hook.
Testing
go vet ./...andgo test ./...pass.