Repository navigation
Conversation
Remove util/HalideTraceViz.cpp, its font and config header, the auto_viz app, the viz.sh scripts and make rules in the apps, and the trace tags in the app generators that only HalideTraceViz consumed. The per-lesson generate_figures_*.sh scripts are replaced by tutorial/figures/generate_figures.py, which renders the tutorial figures directly from lesson traces. Its per-figure parameters reproduce the committed figures: every figure has the same frame count, and the deterministic ones match frame-for-frame up to font and rounding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The packet index is global across the trace, but was being compared against per-Func packet counts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9650 +/- ##
==========================================
+ Coverage 72.78% 72.93% +0.14%
==========================================
Files 264 266 +2
Lines 82985 83337 +352
Branches 20372 20467 +95
==========================================
+ Hits 60404 60783 +379
- Misses 16139 16159 +20
+ Partials 6442 6395 -47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…in CI Draw labels with Pillow's built-in font and encode mp4s with the ffmpeg from imageio-ffmpeg, so the script needs no system fonts or ffmpeg. Its dependencies are in a new "figures" dependency group, which ci-base includes. Add a --check mode that compares rendered figures against the committed ones, and a --lesson-dir option to trace prebuilt lesson binaries. The tutorial_lesson_19_figures CTest uses these to check that the lesson 19 figures, which come from a small deterministic trace, still reproduce. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
halidoscope deprecated most uses of HalideTraceViz. This PR deletes it. The one not-easy-to-replace use was rendering figures for the tutorials. This PR rolls a 600-line python script that does it, replacing all the bash figure generation scripts. It's 400 lines of rendering code and 200 lines of lesson-specific configuration formerly captured in the individual scripts. Claude diffed the deterministic ones against the checked-in figures and I manually checked the non-deterministic (due to parallelism) ones looked correct.
This also deletes the app visualization configs that has been used in the past to generate videos. I think those are better generated by taking a screen recording of hitting play in halidoscope, after manually adjusting layout to taste.
Also a drive-by fix in halidoscope packet indexing that claude discovered while investigating if this could instead be done by invoking halidoscope. It would have been a much larger change to get figures that render the same.