Repository navigation
HCK-18408: comment out the foreign key of a deactivated relationship - #89
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
chulanovskyi-bs
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



## Content
Jira: HCK-18408
When a relationship is deactivated but both tables and their key columns are activated, forward-engineering still generated the foreign key as an active statement. It should be commented out, like other deactivated objects.
Technical details
isActivated, butcreateForeignKeyConstraintonly looked at the tables and the key columns.isActivatednow also takes the relationship flag, the same way the PostgreSQL plugin does it. The columns list is still built like before.!== falseis used so a missing flag (old models) keeps the foreign key activated.createForeignKeyConstraint, there is nocreateForeignKeyhere.getTableConstraintsadded every foreign key to theCREATE TABLEwithout checkingisActivated. Deactivated foreign keys are now put in a commented block after the active constraints, like deactivated columns.Made with Cursor