Skip to content

HCK-18367: fix boolean false in separate column DEFAULT statements #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras-dubyk merged 7 commits into from
Nov 2, 2026
Merged

HCK-18367: fix boolean false in separate column DEFAULT statements #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb77386
Fix template substitution for boolean default false.
Sylvie-P Oct 29, 2026
8238bf5
Fix inline CREATE defaults when boolean default is false.
Sylvie-P Oct 29, 2026
3f3202c
Fix Sonar findings for boolean default handling in getColumnDefault.
Sylvie-P Oct 29, 2026
c49d02e
Fix Sonar false positive on empty-string default check.
Sylvie-P Oct 29, 2026
45fbfc7
Update forward_engineering/ddlProvider/ddlHelpers/columnDefinition/ge…
Sylvie-P Oct 30, 2026
31ca9ff
Use nullish check that satisfies Sonar for column defaults.
Sylvie-P Oct 30, 2026
7087d1a
Merge branch 'develop' into fix/boolean-default-false-separate-statement
Sylvie-P Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions forward_engineering/ddlProvider/ddlHelpers/columnDefinition/getColumnDefault.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { wrapInSingleQuotes } = require('../../../utils/general');
const { DATA_TYPES_WITH_IDENTITY, STRING_DATA_TYPES } = require('../../../../constants/types');

/**
* @typedef {string | number} DefaultValue
* @typedef {string | number | boolean} DefaultValue
*/

/**
Expand Down Expand Up @@ -37,7 +37,7 @@ const getIdentityOptions = ({ start, increment, minValue, maxValue, cycle, cache
};

/**
* @param {{ default?: DefaultValue, identity?: object }}
* @param {{ default?: DefaultValue, identity?: object, type: string }}
* @returns {string}
*/
const getColumnDefault = ({ default: defaultValue, identity, type }) => {
Expand All @@ -49,7 +49,7 @@ const getColumnDefault = ({ default: defaultValue, identity, type }) => {
return ` GENERATED ${identity.generated} AS IDENTITY (${identityOptions})`;
}

if (defaultValue || defaultValue === 0) {
if (defaultValue != null) {
return ` WITH DEFAULT ${defaultValue}`;
}
return '';
Expand Down
6 changes: 5 additions & 1 deletion forward_engineering/utils/assignTemplates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ const assignTemplates = ({ template, templateData }) => {
const templateName = parseTemplate(item);

return result.replace(item, () => {
return templateData[templateName] || templateData[templateName] === 0 ? templateData[templateName] : '';
const value = templateData[templateName];
if (value === undefined || value === null) {
return '';
}
return value;
});
}, template);
};
Expand Down