engine: add static GOST engine support with explicit OpenSSL binding - #535
Open
legale wants to merge 1 commit into
Open
engine: add static GOST engine support with explicit OpenSSL binding#535legale wants to merge 1 commit into
legale wants to merge 1 commit into
Conversation
ENGINE_load_gost() previously created and added the GOST engine to OpenSSL,
but did not explicitly register its PKEY ASN.1 methods.
This was sufficient for the dynamic engine loading path,
but incomplete for direct library/static use where the program
calls ENGINE_load_gost() itself.
As a result, the engine could be found with
ENGINE_by_id("gost"), while GOST-2012 key ASN.1 methods
were still unavailable to libcrypto.
This also caused GOST TLS cipher suites to be rejected by SSL_CTX_set_cipher_list().
Register the engine PKEY ASN.1 methods explicitly after ENGINE_add()
so static and library builds expose GOST-2012 keys correctly
and can use GOST TLS cipher suites.
Signed-off-by: Ruslan Isaev <legale.legale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENGINE_load_gost() previously created and added the GOST engine to OpenSSL, but did not explicitly register its PKEY ASN.1 methods.
This was sufficient for the dynamic engine loading path, but incomplete for direct library/static use where the program
calls ENGINE_load_gost() itself.
As a result, the engine could be found with
ENGINE_by_id("gost"), while GOST-2012 key ASN.1 methods were still unavailable to libcrypto.
This also caused GOST TLS cipher suites to be rejected by SSL_CTX_set_cipher_list().
Register the engine PKEY ASN.1 methods explicitly after ENGINE_add() so static and library builds expose GOST-2012 keys correctly and can use GOST TLS cipher suites.