feat: bump gapic-generator to v1.38.0 - #18057
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator tool version to 1.38.0 and bumps the minimum google-api-core dependency version to 2.28.0 across multiple client post-processing configurations. It also cleans up several obsolete temporary post-processing patches. Regarding the feedback, there is an issue in datastore-integration.yaml where including .. include:: README.rst in the replacement block will cause duplicate content in the generated documentation.
| after: | | ||
| .. include:: README.rst | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
The before pattern matches starting from .. include:: multiprocessing.rst. Since .. include:: README.rst precedes this line in the generated index.rst file, it is not matched and will be preserved at the top of the file. Including .. include:: README.rst in the after block will therefore cause it to be duplicated in the final output. Removing it from the after block will prevent this duplication.
after: |
.. note::
quirogas
left a comment
There was a problem hiding this comment.
The changes to librarian.yaml look good to me. Let's wait for the generation tests to pass before merging this portion of the PR, though.
be4715e to
d7c3edb
Compare
parthea
left a comment
There was a problem hiding this comment.
This PR contains changes to the post processing scripts which are not related to the update to gapic-generator==1.38.0. Please could you pull those changes out and propose them separately?
d7c3edb to
54694ba
Compare
f268e91 to
59e6065
Compare
e965abe to
bf12ed7
Compare
Description
gapic-generatorversion to1.38.0inlibrarian.yaml.Regenerates all packages and preview-packages with
gapic-generatorv1.38.0 vialibrarian generate --all.Steps to Reproduce the Full Regeneration Diff
1. Prerequisites & Environment Setup
Ensure Go, Python 3.11+, and
protoc(libprotoc 33.1/33.5) are installed and available in your$PATH:2. Clean Locks, Synthtool Cache, & Export Template Directory
Synthtool caches templates locally under
~/.cache/synthtool/synthtool. Clear any stale locks, ensure a clean template clone, and export the template path:3. Clean Stale Workspace Artifacts
Remove any temporary build/staging directories left over from previous runs:
4. Install Dependencies via Librarian
Install the exact tool versions specified in
librarian.yaml(includinggapic-generator 1.38.0, formatters, and linters):5. Run Librarian Generation
Run librarian to regenerate all packages across the repository:
6. Post-Generation Cleanup
Remove temporary staging artifacts:
Note: updates to post-processing scripts in a separate PR stacked on top of this one.