Skip to content

feat: bump gapic-generator to v1.38.0 - #18057

Draft
hebaalazzeh wants to merge 1 commit into
post-processing-script-updatesfrom
update-gapic-generator-v1.38
Draft

feat: bump gapic-generator to v1.38.0#18057
hebaalazzeh wants to merge 1 commit into
post-processing-script-updatesfrom
update-gapic-generator-v1.38

Conversation

@hebaalazzeh

@hebaalazzeh hebaalazzeh commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

  • Bumps gapic-generator version to 1.38.0 in librarian.yaml.

Regenerates all packages and preview-packages with gapic-generator v1.38.0 via librarian generate --all.

Steps to Reproduce the Full Regeneration Diff

1. Prerequisites & Environment Setup

Ensure Go, Python 3.11+, and protoc (libprotoc 33.1 / 33.5) are installed and available in your $PATH:

# Verify protoc version
protoc --version

# Create and activate a Python virtual environment
python3 -m venv .venv
source .venv/bin/activate

# Install synthtool in the environment
pip install synthtool

2. Clean Locks, Synthtool Cache, & Export Template Directory

Synthtool caches templates locally under ~/.cache/synthtool/synthtool. Clear any stale locks, ensure a clean template clone, and export the template path:

# Remove any stale git locks if present
rm -f .git/index.lock
rm -f "$HOME/.cache/synthtool/synthtool/.git/index.lock"

# Clean existing synthtool cache
rm -rf "$HOME/.cache/synthtool/synthtool"

# Clone the latest synthtool repository
git clone https://github.com/googleapis/synthtool.git "$HOME/.cache/synthtool/synthtool"

# Export the templates path required by synthtool
export SYNTHTOOL_TEMPLATES="$HOME/.cache/synthtool/synthtool/synthtool/gcp/templates"

3. Clean Stale Workspace Artifacts

Remove any temporary build/staging directories left over from previous runs:

rm -rf packages/*/tmp preview-packages/*/tmp

4. Install Dependencies via Librarian

Install the exact tool versions specified in librarian.yaml (including gapic-generator 1.38.0, formatters, and linters):

go run github.com/googleapis/librarian/cmd/librarian@v0.31.0 install

5. Run Librarian Generation

Run librarian to regenerate all packages across the repository:

go run github.com/googleapis/librarian/cmd/librarian@v0.31.0 generate --all

6. Post-Generation Cleanup

Remove temporary staging artifacts:

rm -rf packages/*/tmp preview-packages/*/tmp

Note: updates to post-processing scripts in a separate PR stacked on top of this one.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator tool version to 1.38.0 and bumps the minimum google-api-core dependency version to 2.28.0 across multiple client post-processing configurations. It also cleans up several obsolete temporary post-processing patches. Regarding the feedback, there is an issue in datastore-integration.yaml where including .. include:: README.rst in the replacement block will cause duplicate content in the generated documentation.

Comment on lines 46 to 49
after: |
.. include:: README.rst

.. note::

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The before pattern matches starting from .. include:: multiprocessing.rst. Since .. include:: README.rst precedes this line in the generated index.rst file, it is not matched and will be preserved at the top of the file. Including .. include:: README.rst in the after block will therefore cause it to be duplicated in the final output. Removing it from the after block will prevent this duplication.

    after: |
      .. note::

@quirogas quirogas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to librarian.yaml look good to me. Let's wait for the generation tests to pass before merging this portion of the PR, though.

@hebaalazzeh
hebaalazzeh marked this pull request as ready for review August 10, 2026 22:11
@hebaalazzeh
hebaalazzeh requested review from a team as code owners August 10, 2026 22:11
@quirogas quirogas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 10, 2026
@hebaalazzeh
hebaalazzeh force-pushed the update-gapic-generator-v1.38 branch 7 times, most recently from be4715e to d7c3edb Compare August 11, 2026 08:03

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains changes to the post processing scripts which are not related to the update to gapic-generator==1.38.0. Please could you pull those changes out and propose them separately?

@hebaalazzeh
hebaalazzeh force-pushed the update-gapic-generator-v1.38 branch from d7c3edb to 54694ba Compare August 11, 2026 16:36
@hebaalazzeh hebaalazzeh changed the title feat: bump gapic-generator to v1.38.0 and update post-processing scripts feat: bump gapic-generator to v1.38.0 Aug 11, 2026
@hebaalazzeh
hebaalazzeh requested review from a team as code owners August 11, 2026 18:50
@hebaalazzeh
hebaalazzeh requested review from sycai and removed request for a team and sycai August 11, 2026 18:51
@hebaalazzeh
hebaalazzeh marked this pull request as draft August 11, 2026 18:54
@hebaalazzeh
hebaalazzeh force-pushed the update-gapic-generator-v1.38 branch from f268e91 to 59e6065 Compare August 11, 2026 18:59
@hebaalazzeh
hebaalazzeh force-pushed the update-gapic-generator-v1.38 branch 2 times, most recently from e965abe to bf12ed7 Compare August 11, 2026 19:20
@hebaalazzeh
hebaalazzeh changed the base branch from main to post-processing-script-updates August 11, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants