Repository navigation
[bot] Merge master/60ce9f66 into rel/dev - #1912
Merged
Merged
Conversation
Moving or removing a widget, and removing or retyping a filter, leave nothing for the existing dashboard checks to see. `charts_matched` and `preserved_widgets` ask whether a chart is still on the dashboard, so a move that never happened, or left a second copy behind, passes, and so does a removal that never happened. `filters` ignores filters beyond the expected ones, and `tab_filters` reads only tabbed dashboards and needs every filter's key in advance, which the agent mints at run time for a new or re-added filter.
Two opt-in expectation keys close that:
- `layout`: per tab, the exact sections in order, each with its exact charts in order (an id, or `{"title"}` for an authored chart), and the section title when stated. Scored as `dashboard_layout_correct`.
- `filter_bar`: per tab, the exact filters, the kept ones by key under `filters` and the ones with a minted key matched by content under `added`. Anything left over fails, an empty filter group included. A grouped filter counts by its own key and names its group's title as `group`; without it, the filter must stand outside every group, so a move into or out of a group fails. It reads a dashboard without tabs too. Scored as `dashboard_filter_bar_correct`.
An entry without `tab` applies only to a dashboard with one tab, and must be the only entry. `tab_filters` now runs through the same check, so the two read filter groups alike; no existing item names a group, and re-scoring 103 saved `tab_filters` runs changes no verdict. A malformed entry is rejected before the first request. Without either key, nothing changes for existing items.
Re-scored against 93 saved runs of the QA-29514 items on ecommerce_demo, the results match the expected outcome of every run.
jira: QA-29514
risk: low
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(gooddata-eval): score dashboard layout and the exact filter bar
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1912 +/- ##
===========================================
+ Coverage 85.75% 85.83% +0.07%
===========================================
Files 343 343
Lines 25182 25322 +140
===========================================
+ Hits 21595 21735 +140
Misses 3587 3587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 60ce9f6 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/40991137353).