Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z8iBZ2KQLeHeYms5c9reX
Owner
Author
|
Closing without merging. Luis decided on a simpler approach (#52): each PR picks its version when opened, and a taken number is renumbered when the PR is synced with Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump type: patch (tooling). Independent PR: it branches from
masterand targetsmaster.Summary
Adds a GitHub Actions Version check to every PR into
master. A red check means the PR isn't finalized and shouldn't be merged. This covers the case where Luis merges on GitHub himself without asking Claude to finalize first.Requested by Luis in chat on 2026-11-03: "Add the check, thats smart." It enforces the versioning rules proposed in #52.
What it checks
.github/scripts/check-version.py, run by.github/workflows/version-check.yml:## [Unreleased]entry.master's. That means nothing was bumped, or another PR merged first with the same number.index.html, README (header and footer), Settings → General inviews-settings.js, or CLAUDE.md §1 shows a different number from CHANGELOG.Each failure says what to do next.
It also updates CLAUDE.md §17 (describes the check) and adds an
[Unreleased]CHANGELOG entry.How it was tested
The script was run locally against real files:
[Unreleased])Not verified: a run on GitHub's own runners. That starts when this PR opens, and it should fail, because this PR isn't finalized yet.
Effect on open PRs
master): GitHub runs the workflow from the merge of each PR withmaster, so they get the check on their next push or re-run after this merges. Both carry a real version, so they should pass, as v1.10.6: Content Security Policy + SRI on every CDN script #22 did locally.master, so the check doesn't run on them. They aren't touched.[Unreleased]entry at the top of CHANGELOG. Whichever of the two merges second gets a small conflict there; resolve it by keeping both entries.How to check
.github/, plusCHANGELOG.mdand CLAUDE.md §17.Generated by Claude Code