Skip to content

CI: version check fails PRs that aren't finalized - #53

Closed
gitluis wants to merge 1 commit into
masterfrom
version-check
Closed

gitluis wants to merge 1 commit into
masterfrom
version-check

Conversation

@gitluis

@gitluis gitluis commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Bump type: patch (tooling). Independent PR: it branches from master and targets master.

Summary

Adds a GitHub Actions Version check to every PR into master. A red check means the PR isn't finalized and shouldn't be merged. This covers the case where Luis merges on GitHub himself without asking Claude to finalize first.

Requested by Luis in chat on 2026-11-03: "Add the check, thats smart." It enforces the versioning rules proposed in #52.

What it checks

.github/scripts/check-version.py, run by .github/workflows/version-check.yml:

  1. Not finalized: CHANGELOG.md still has a ## [Unreleased] entry.
  2. No new version: the top CHANGELOG version isn't higher than master's. That means nothing was bumped, or another PR merged first with the same number.
  3. Version spots out of step: the sidebar footer in index.html, README (header and footer), Settings → General in views-settings.js, or CLAUDE.md §1 shows a different number from CHANGELOG.

Each failure says what to do next.

It also updates CLAUDE.md §17 (describes the check) and adds an [Unreleased] CHANGELOG entry.

How it was tested

The script was run locally against real files:

Case Result
This branch as is ([Unreleased]) ❌ "not finalized"
Simulated finalize to v1.10.6, CLAUDE.md §1 forgotten ❌ names CLAUDE.md §1
Simulated finalize to v1.10.6, complete ✅ passes
Same, but another PR already merged v1.10.6 ❌ "not higher than master's v1.10.6"
Open PR #22 (v1.10.6, finalized the old way) ✅ passes

Not verified: a run on GitHub's own runners. That starts when this PR opens, and it should fail, because this PR isn't finalized yet.

Effect on open PRs

How to check

  1. Checks tab on this PR: Version check ran and failed with the "not finalized" message. That's expected.
  2. Files changed: two new files under .github/, plus CHANGELOG.md and CLAUDE.md §17.
  3. Before merging: ask Claude to finalize. After the finalize commit, the check should turn green.
  4. Optional: once the repo is public or on GitHub Pro, make Version check a required status check in branch protection. Then GitHub itself blocks the merge button.

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z8iBZ2KQLeHeYms5c9reX
@gitluis gitluis added the ci CI, GitHub Actions and repo tooling label Nov 3, 2026 — with Claude

gitluis commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

Closing without merging. Luis decided on a simpler approach (#52): each PR picks its version when opened, and a taken number is renumbered when the PR is synced with master. A CI check isn't needed for that. The version-check branch is kept in case it's useful later.


Generated by Claude Code

@gitluis gitluis closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI, GitHub Actions and repo tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants