Repository navigation
Conversation
0.2.0 narrows Actor.user_id to users and agents, so get_acting_user_id delegates to it instead of repeating the type check.
github-actions
Bot
added
the
Scope: Backend
Contributor
Backend Test FailuresFailures on
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
sentry-viewercontextto 0.2.0 (getsentry/viewercontext#8), which narrowsActor.user_idto user and agent actors; other actor types now returnNoneinstead of theirdelegated_user_id.That's the rule
get_acting_user_idalready implemented by hand, so it now just delegates toactor.user_id. No behavior change for Sentry; Seer gets the same semantics in its matching bump.