Repository navigation
ref(np): Remove unused stage from notification tracking - #128727
Open
hobzcalvin wants to merge 1 commit into
Open
hobzcalvin wants to merge 1 commit into
hobzcalvin wants to merge 1 commit into
Conversation
Nothing sets stage, and a notification's source already identifies what was sent, so drop it from the tracking context, metric tags, and analytics events.
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing sets stage, and a notification's source already identifies what was sent, so drop it from the tracking context, metric tags, and analytics events.
This was basically me not noticing the agent adding this in, and now I realize we don't want to do something special just for Seer Autofix (which renders separate "stages" from a single template). So we'll just track all autofix links as a singe
source, which I think is fine, at least until we know we want more granularity.