Skip to content

fix(seer): Keep service account actors when resolving Seer viewer context - #128718

Open
gricha wants to merge 1 commit into
masterfrom
fix/seer-viewer-context-service-account
Open

gricha wants to merge 1 commit into
masterfrom
fix/seer-viewer-context-service-account

Conversation

@gricha

@gricha gricha commented Oct 23, 2026

Copy link
Copy Markdown
Member

When a call to Seer passes an explicit SeerViewerContext with a user_id, _resolve_viewer_context replaced any non-user, non-agent actor with a USER actor for that id, without logging a mismatch. For a service account that means Seer receives — and echoes back — a context that Sentry then authenticates as a human.

A service account is now kept as-is: the explicit user_id is treated as a mismatch (warning logged, superuser and project stripped). SYSTEM / INTEGRATION / UNKNOWN still adopt the explicit user, since tasks and webhooks rely on that to attribute work to a user.

No service-account producers exist yet; this needs to land before they do. Stacked on #128628.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@gricha
gricha marked this pull request as ready for review October 23, 2026 22:56
@gricha
gricha requested a review from a team as a code owner October 23, 2026 22:56
@gricha
gricha force-pushed the fix/seer-viewer-context-service-account branch from 3ee4732 to e647437 Compare October 23, 2026 23:06
@gricha
gricha force-pushed the ref/use-viewercontext-lib branch from fee7d0f to 0a10c37 Compare October 23, 2026 23:06
Base automatically changed from ref/use-viewercontext-lib to master October 23, 2026 23:26
@gricha
gricha requested review from a team as code owners October 23, 2026 23:26
…text

An explicit SeerViewerContext user_id replaced a service-account actor
with that user, so Seer's echoed context authenticated as a human.
@gricha
gricha force-pushed the fix/seer-viewer-context-service-account branch from e647437 to 2b7f674 Compare October 24, 2026 01:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant