Repository navigation
Conversation
gricha
marked this pull request as ready for review
October 23, 2026 22:56
gricha
force-pushed
the
fix/seer-viewer-context-service-account
branch
from
October 23, 2026 23:06
3ee4732 to
e647437
Compare
gricha
force-pushed
the
ref/use-viewercontext-lib
branch
from
October 23, 2026 23:06
fee7d0f to
0a10c37
Compare
…text An explicit SeerViewerContext user_id replaced a service-account actor with that user, so Seer's echoed context authenticated as a human.
gricha
force-pushed
the
fix/seer-viewer-context-service-account
branch
from
October 24, 2026 01:45
e647437 to
2b7f674
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a call to Seer passes an explicit
SeerViewerContextwith auser_id,_resolve_viewer_contextreplaced any non-user, non-agent actor with a USER actor for that id, without logging a mismatch. For a service account that means Seer receives — and echoes back — a context that Sentry then authenticates as a human.A service account is now kept as-is: the explicit
user_idis treated as a mismatch (warning logged, superuser and project stripped). SYSTEM / INTEGRATION / UNKNOWN still adopt the explicit user, since tasks and webhooks rely on that to attribute work to a user.No service-account producers exist yet; this needs to land before they do. Stacked on #128628.