Skip to content

feat(investigations): Read and build monitor changes for update_detector - #128671

Open
wedamija wants to merge 3 commits into
masterfrom
danf/inv-fu-15-update-detector-payloads
Open

wedamija wants to merge 3 commits into
masterfrom
danf/inv-fu-15-update-detector-payloads

Conversation

@wedamija

@wedamija wedamija commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds the adapter between an update_detector change and the detector API. It reads the monitor's current settings and builds the partial update from the same serialized state.

@wedamija
wedamija requested review from a team as code owners October 23, 2026 17:33
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@wedamija
wedamija requested a review from billyvg October 23, 2026 17:34
Base automatically changed from danf/inv-fu-14-can-apply to master October 23, 2026 17:35

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79d7090. Configure here.

Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted review, posted on behalf of @billyvg.

Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted review, posted on behalf of @billyvg.

Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
Comment thread src/sentry/investigations/services/action_kinds/update_detector.py Outdated
@wedamija wedamija changed the title feat(investigations): Validate update_detector changes against the monitor feat(investigations): Read and build monitor changes for update_detector Oct 23, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This adds the adapter between an update_detector change and the detector API. It reads the monitor's current settings and builds the partial update from the same serialized state.
@wedamija
wedamija force-pushed the danf/inv-fu-15-update-detector-payloads branch from 51f2bcf to d30261b Compare October 23, 2026 23:28
wedamija added a commit that referenced this pull request Oct 23, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This registers the update_detector action kind. Reads say whether the viewer can apply a monitor change, using the detector endpoint's own plan and permission checks.

Depends on #128671
@wedamija
wedamija requested a review from billyvg October 23, 2026 23:41
…g it

Some span monitors migrated from transactions store an extrapolation mode the validator rejects, so every window or query change on them failed. The update leaves the mode out, so the stored one is kept.
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This registers the update_detector action kind. Reads say whether the viewer can apply a monitor change, using the detector endpoint's own plan and permission checks.

Depends on #128671
wedamija added a commit that referenced this pull request Oct 24, 2026
Part of a series that adds follow-up actions to Seer investigations: when a run completes, Seer suggests one next step, and the user can apply a typed action, such as a monitor change, with one click.

This registers the update_detector action kind. Reads say whether the viewer can apply a monitor change, using the detector endpoint's own plan and permission checks.

Depends on #128671

This branch was successfully deployed

1 active (outdated) deployment
Preview — 79d70909 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants