Skip to content

fix(github): use one branch for status notification title and Branch field - #441

Merged
dnyw4l3n13 merged 2 commits into
mainfrom
fix/434-status-branch-consistency
Oct 30, 2026
Merged

dnyw4l3n13 merged 2 commits into
mainfrom
fix/434-status-branch-consistency

Conversation

@prpixie

@prpixie prpixie commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Status notifications used different branches for the embed title and the Branch field. The notification now picks one branch consistently for both: prefer release/*, then main, else the first branch.

This PR currently contains the placeholder CHANGELOG.md entry; the code change is to follow.

Closes #434

@prpixie prpixie added the auto-pr Pull request created automatically label Oct 30, 2026
@dnyw4l3n13 dnyw4l3n13 changed the title docs(changelog): placeholder for #434 fix(github): use one branch for status notification title and Branch field Oct 30, 2026
@dnyw4l3n13 dnyw4l3n13 added AI-Work Work for an AI Agent High High Priority labels Oct 30, 2026
@credfeto

Copy link
Copy Markdown
Member

Roslyn analyzer findings

Source Rule Level File Line Suppressed Message
DotNet CA2000 error src/BuildBot/Helpers/ServerStartup.cs 99 yes Call System.IDisposable.Dispose on object created by 'CreateLogger()' before all references to it are out of scope

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Implemented #434 in e59b7ad: title and Branch field now share one branch choice (release/* > main > first > (unknown)), with tests. Next: CI, then simplify.

Add changelog entry for the status notification branch consistency fix (#434).
@dnyw4l3n13
dnyw4l3n13 force-pushed the fix/434-status-branch-consistency branch from e59b7ad to ffaa24c Compare October 30, 2026 15:28
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Simplify clean - advancing to code review

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Code review clean - advancing to security review

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Security review clean, advancing to coverage check

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Coverage ratchet passed - advancing to Human Review (.NET hand-written code 100.0% vs main 100.0%; only generated code is uncovered; COVERAGE.md unchanged).

@dnyw4l3n13
dnyw4l3n13 marked this pull request as ready for review October 30, 2026 15:49
@dnyw4l3n13
dnyw4l3n13 requested a review from a team as a code owner October 30, 2026 15:49
@dnyw4l3n13
dnyw4l3n13 enabled auto-merge October 30, 2026 15:49
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Finalize: PR marked ready and auto-merge enabled.

@credfeto

Copy link
Copy Markdown
Member

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@dnyw4l3n13
dnyw4l3n13 merged commit 454bc37 into main Oct 30, 2026
41 checks passed
@dnyw4l3n13
dnyw4l3n13 deleted the fix/434-status-branch-consistency branch October 30, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent auto-pr Pull request created automatically High High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(github): Status notifications use different branches in title and Branch field

3 participants