Skip to content

Keep first menu actions across media-query transitions - #332

Merged
silveltman merged 5 commits into
mainfrom
fix/media-request-before-change-20261024
Oct 24, 2026
Merged

silveltman merged 5 commits into
mainfrom
fix/media-request-before-change-20261024

Conversation

@silveltman

@silveltman silveltman commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Keep the first menu action when CSS reaches its breakpoint before the browser delivers the media-query notification. A delayed import must also discard an open request when any current action or import observes media exit, so returning to mobile cannot reopen a cancelled menu.

The helper reads the current query at activation and mounting, preserves pending actions through matching notifications, and clears them on every observed exit. Obsolete imports cannot mount or cancel a newer request. Header blocks continue to own breakpoint policy. No API, design or dependency changes.

Validation:

  • Full source check passes: 991 files, 0 errors/warnings/hints. Production build and artifact checks pass.
  • All 45 unit tests and all 39 Chromium, Firefox and WebKit lifecycle cases pass, including actual headers at both folds.
  • Final-source input hashes match before and after validation. The matching hosted preview serves all eight exact registry items. Documentation search and actual-header mobile/desktop/mobile, Enter, Escape and focus restoration pass. Required CI confirms these checks after Ready.

The 12 focused entry/exit cases pass. Negative controls reproduce each cancellation defect against the preceding source. Independent re-review found no remaining source defects. All eight generated registry styles exactly match the final helper. Prior native iOS evidence covers unchanged input/controller behavior.

@netlify

netlify Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fulldev-ui ready!

Name Link
🔨 Latest commit caced07
🔍 Latest deploy log https://app.netlify.com/projects/fulldev-ui/deploys/6adccd984952c5d60c8c4d46
😎 Deploy Preview https://deploy-preview-332--fulldev-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@silveltman
silveltman marked this pull request as ready for review October 24, 2026 15:27
@silveltman
silveltman merged commit 2fd3fd7 into main Oct 24, 2026
9 checks passed
@silveltman
silveltman deleted the fix/media-request-before-change-20261024 branch October 24, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant