Repository navigation
fix: correct the pkcs11 extra and drop libnacl - #80
Open
shcheklein wants to merge 1 commit into
Open
shcheklein wants to merge 1 commit into
shcheklein wants to merge 1 commit into
Conversation
asyncssh names its extra `pkcs11`, so `sshfs[pkcs11]` installed nothing. asyncssh 2.23.0 removed libnacl support and its `libnacl` extra. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the extras that sshfs passes through to asyncssh don't exist in asyncssh:
pkcs11 = ["asyncssh[python-pkcs11]"]: asyncssh calls this extrapkcs11, sosshfs[pkcs11]has never installedpython-pkcs11. This dates back tosetup.cfg.libnacl = ["asyncssh[libnacl]"]: asyncssh 2.23.0 removed libnacl support ("now that these are available in all supported versions of the cryptography package"), and with it the extra. On asyncssh 2.23+ (Python 3.10+),sshfs[libnacl]installs nothing.This PR renames the first extra and removes the second. With the old extras,
uv lockwarns:With this change, it resolves with no warnings and locks
python-pkcs11(0.9.4 on Python 3.9, 0.10.1 on 3.10+). The same warnings show up in every job of #79's uv-based test run.Removing
libnaclmeanspip install sshfs[libnacl]now prints a pip warning about an unknown extra instead of silently installing nothing. On Python 3.9, which is capped at asyncssh 2.21.1, it no longer installs libnacl. asyncssh 2.21 only used libnacl as a fallback when OpenSSL was too old.🤖 Generated with Claude Code