Repository navigation
Conversation
On GNOME Shell 51 opening some apps (reliably Google Chrome) crashed the whole shell with SIGSEGV in meta_window_set_unmaximize_flags, preceded by "meta_window_move_resize_internal: runtime check failed: (priv->is_ready)". Forge unmaximized and positioned new windows from a fixed 200 ms timer. Slow-starting clients are not configured by then, and mutter 51 no longer tolerates geometry changes on such windows. - Mark windows from "window-created" as awaiting their first frame and render them once the actor emits "first-frame". - Skip those windows in move() and in the live-resize neighbour layout, which calls move_resize_frame() directly. - Only unmaximize windows that are actually maximized, using get_maximize_flags() on GNOME 49+. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With "make -j<n>" the prerequisites of "build: clean ..." run concurrently, so "clean" can delete schemas/gschemas.compiled right after it was compiled. The installed extension then fails to load with "gschemas.compiled ... not found". Serialize the Makefile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Make the Makefile safe for parallel make (Commit 55c5cb4)With Adds |
ikaru5
changed the title
Meta.MaximizeFlags.NONE only exists since mutter 51. On GNOME 49 and 50 it is undefined, so the check in _unmaximize() was always true and called set_unmaximize_flags(0) for windows that are not maximized. Mutter 50 asserts that at least one direction is set and aborts the shell (seen on Bluefin, GNOME 50.5, right after login). Compare against 0 instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Found a regression on GNOME 50.5 (Bluefin): Tested on GNOME 50.5 / Bluefin and GNOME 51.0 / Arch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On GNOME Shell 51, opening some apps (reliably Google Chrome) crashes the whole
shell (SIGSEGV) and logs the user out. Backtrace ends in
meta_window_set_unmaximize_flagscalled from GJS, preceded by:Forge unmaximizes and positions new windows from a fixed 200 ms timer. Slow
clients aren't configured yet at that point, and mutter 51 crashes on geometry
changes to such windows.
Fix
window-createdare marked as awaiting their first frame andlaid out once the actor emits
first-frame.move()and_liveResizeNeighbors()(which callsmove_resize_frame()directly) skip those windows.
get_maximize_flags()on GNOME 49+ (pre-49 fallback kept).Testing